Uh oh!
There was an error while loading. Please reload this page.
Turn all short aliases into long form - #474
Conversation
To make things more readable, we'll shift our documentation to use long form arguments by default. Starting from the common aliases R, J, B, U, CPT, G and W.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Also added timestamp (U) alias to the plotting functions that have them. Co-Authored-By: Dongdong Tian <seisman.info@gmail.com>
seisman
commented
Jun 2, 2020
Perhaps we should update all the short-form arguments (if they have aliases) in this PR, not to update them in multiple PRs. I can help with it if you also agree. |
weiji14
commented
Jun 2, 2020
Might as well. I'll work on |
seisman
commented
Jun 2, 2020
OK. |
Also standardize formatting of grdtrack docstring in line with other docs.
Alright, |
seisman
commented
Jun 2, 2020
Yes, just ignore it. |
Also document the required imagefile parameter that was missing.
| be plotted. | ||
| At least one of the options *B*, *L*, or *T* must be specified. | ||
| At least one of the options *frame*, *L*, or *T* must be specified. |
There was a problem hiding this comment.
I've only changed B to frame here for basemap. GMT.jl uses map_scale for L, rose for Td and compass for Tm (see https://www.generic-mapping-tools.org/GMT.jl/latest/#GMT.basemap), do we want to go with those?
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
Do you want to take a look at https://pygmt-git-longaliascommonopts.gmt.now.sh/api/index.html to see if we missed any stray short aliases (other than the ones we agreed not to change)? P.S. Not a user facing change, but we should also update all the tests to use the long alias names at some point. |
seisman
commented
Jun 4, 2020
Made a small fix. Now it's good to me.
Yes, I agree. |
Description of proposed changes
To make things more readable, we'll shift our documentation to use long form arguments by default. Starting from the common aliases R, J, B, U, CPT, G and W. Will move on to all others spread across across the API Reference page.
See also upstream GMT docs at https://docs.generic-mapping-tools.org/latest/std-opts.html.
New looking documentation for this branch can be previewed at https://pygmt-git-longaliascommonopts.gmt.now.sh/api/index.html
Files to change:
Fixes#473
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.