Uh oh!
There was an error while loading. Please reload this page.
README: Reorganize the Contributing section - #4793
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our "Imposter syndrome disclaimer" was adapted from the MetPy project. After reviewing the MetPy README (https://github.com/Unidata/MetPy#code-of-conduct), I feel that their structure is more appropriate.
Previously, "Code of Conduct" was a subsection under "Contributing". However, the Code of Conduct applies not only to contributing but also to other project-related activities, such as asking questions on forums. Therefore, this PR promotes "Code of Conduct" from a level-3 heading to a level-2 heading.
Currently, we have two separate subsections: "Contributing Guidelines" and "Imposter syndrome disclaimer". Following the MetPy style, this PR combines these two subsections into a single section.
Our "Imposter syndrome disclaimer" is now different from the MetPy one, I wonder if we should just update ours to match the MetPy one. If yes, then it should be done in a separate PR.
Preview: https://github.com/GenericMappingTools/pygmt/tree/readme/coc