Uh oh!
There was an error while loading. Please reload this page.
Unpin pylint version and fix some lint warnings - #484
Merged
Conversation
seisman
commented
Jun 21, 2020
Member
pylint-dev/astroid#649 (comment)
I guess @leouieda pinned pylint for the same reason. |
weiji14force-pushed
the
unpin_pylint_version
branch
from
June 23, 2020 12:19
d1c2c2b to
9781ed4CompareRun v2.5.3 of pylint: `pylint --generate-rcfile > .pylintrc`, and then manually keeping some old PyGMT specific settings. E.g. jobs=4; max-module-lines=2000; max-args=10; max-attributes=10; good-names=i,j,k,ex,Run,_,w,e,s,n,x,y,z. Add back 'attribute-defined-outside-init' and 'bad-continuation' to the disable list, the latter is to fit in with black (see psf/black#48).
Allow importing certain modules outside of toplevel.
As suggested by Sourcery in https://github.com/weiji14/pygmt/pull/103/files#r444579519.
seisman
reviewed
Jun 26, 2020
Uh oh!
There was an error while loading. Please reload this page.
seisman
commented
Jun 26, 2020
Member
Please merge the master branch in and see if the CI pass (still 43 failures). |
See https://stackoverflow.com/a/61139278. Co-Authored-By: Dongdong Tian <seisman.info@gmail.com>
seisman
commented
Jun 26, 2020
Member
There is still one warning for me: but I'm using pylint 2.4.4 |
weiji14
commented
Jun 26, 2020
Uh oh!
There was an error while loading. Please reload this page.
seisman
approved these changes
Jun 27, 2020
So that both pylint 2.4.4 and 2.5.3 will be happy.
5 tasks
5 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Not sure why pylint was pinned to 2.2.2 in #383, but it's broken and we'll need to update to 2.3.0 or newer (see pylint-dev/astroid#649). Using 2.2.2 will give the following error:
Will also fix some lint warnings in this PR. I've refreshed the
.pylintrcfile for pylint v2.5.3 by running:and then manually kept some old PyGMT specific settings from earlier PRs (e.g. #73).
Also added back 'attribute-defined-outside-init' and 'bad-continuation' to the disable list, the latter is to fit in with black (see psf/black#48).
References:
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.