Uh oh!
There was an error while loading. Please reload this page.
Unpin the Sphinx version - #629
Merged
Merged
Conversation
weiji14
commented
Sep 23, 2020
Member
So sphinx and sphinx_rtd_theme was pinned at #383, and the main change I notice is a condensed API documentation? Old (current):New (This PR):Doesn't look too bad 😄 |
seisman
commented
Sep 23, 2020
MemberAuthor
weiji14
commented
Sep 23, 2020
Member
Yeah it does. I do like how the vertical whitespace is compressed (for the Aliases especially). Maybe we can configure it somehow (looking at https://sphinx-rtd-theme.readthedocs.io/en/stable/index.html), or pin to a different version? |
seisman
commented
Sep 23, 2020
MemberAuthor
Note that we also have a custom style.css which may or may not be compatible with new sphinx and sphinx_rtd_theme. |
seisman
commented
Dec 15, 2020
MemberAuthor
It seems unpinning the sphinx version doesn't change the appearance of the API documentation. Can we merge the PR? |
weiji14
approved these changes
Dec 15, 2020
weiji14
left a comment
Member
There was a problem hiding this comment.
Interesting, good to unpin it then!
7 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description of proposed changes
Fixes #
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.