Skip to content

Add tutorial for adding a map title - #720

Merged
seisman merged 14 commits into
GenericMappingTools:masterfrom
willschlitzer:add-title
Dec 11, 2020
Merged

Add tutorial for adding a map title#720
seisman merged 14 commits into
GenericMappingTools:masterfrom
willschlitzer:add-title

Conversation

@willschlitzer

@willschlitzerwillschlitzer commented Dec 8, 2020•
edited by seisman
Loading

Copy link
Copy Markdown
Contributor

Adding tutorial for adding a figure title, as requested in #335.

Closes#335.

@weiji14weiji14 added the documentation Improvements or additions to documentation label Dec 8, 2020
weiji14
weiji14 reviewed Dec 8, 2020
View reviewed changes

@weiji14weiji14 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Big thanks for doing this (and all your other work around PyGMT) @willschlitzer! Always nice to have some fresh eyes on our documentation. Just one minor comment on the backslash syntax for now.

Comment threadexamples/tutorials/frames.py Outdated
@willschlitzer@weiji14
Update examples/tutorials/frames.py
7146cd1
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@willschlitzer

willschlitzer commented Dec 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Could I get one of the maintainers to look at my most recent commit? I can't figure out why it failed so many tests and deployment.

@seisman

seisman commented Dec 9, 2020

Copy link
Copy Markdown
Member

I think it's unrelated to your PR. I just re-triggered the CI jobs.

seisman
seisman reviewed Dec 9, 2020
View reviewed changes
Comment threadexamples/tutorials/frames.py Outdated
Comment threadexamples/tutorials/frames.py
Comment threadexamples/tutorials/frames.py Outdated
@seismanseisman changed the title Add titleAdd tutorial for adding a map titleDec 9, 2020
seisman
seisman reviewed Dec 10, 2020
View reviewed changes
Comment threadexamples/tutorials/frames.py Outdated
@willschlitzer@seisman
Update examples/tutorials/frames.py
db1b022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@willschlitzer
willschlitzer marked this pull request as ready for review December 10, 2020 17:16
seisman
seisman reviewed Dec 10, 2020
View reviewed changes
Comment threadexamples/tutorials/frames.py Outdated
@willschlitzer@seisman
Update examples/tutorials/frames.py
b591edd
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman

seisman commented Dec 10, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@willschlitzer

It looks good now. Please do two more things:

  1. Merge the master branch, by clicking the "Update branch" button.
  2. Fix the styling issue. You can run make format locally, or you can just write /format in the first line of a comment to automatically format the codes (a feature introduced in Add slash command "/format" to automatically format PRs #646).

@seismanseisman added this to the 0.3.0 milestone Dec 11, 2020
@seisman
seisman merged commit 862bd77 into GenericMappingTools:masterDec 11, 2020
@seismanseisman mentioned this pull request Dec 11, 2020
Closed
@willschlitzer
willschlitzer deleted the add-title branch December 16, 2020 15:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weiji14weiji14weiji14 left review comments
@seismanseismanseisman approved these changes

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

[Easy task if you know some sphinx] Add example for setting map title

3 participants

@willschlitzer@seisman@weiji14