Uh oh!
There was an error while loading. Please reload this page.
Let load_earth_relief() support 'region' argument for all resolutions - #873
Merged
Conversation
seisman
marked this pull request as ready for review
February 12, 2021 18:46
5 tasks
weiji14
approved these changes
Feb 12, 2021
weiji14
left a comment
Member
There was a problem hiding this comment.
Implementation looks good, agree that we should allow the region argument for low-resolution grids too, even if it might cause issues when users apply operations (e.g. slicing) on top of those grids. Cheers too for updating the docs!
As an aside, I've made a note at #524 (comment) about how upstream xarray is trending on keep_attrs by default.
sixy6e pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
…GenericMappingTools#873) * Let load_earth_relief() support 'region' argument for all resolutions * Improve docstrings of load_earth_relief()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
In #542, we extended the
load_earth_relief()function to support all resolutions, and also allowregionargument for high-resolution grids (>=05m). We had some discussions (#542 (comment)) and decided not to allowregionfor low-resolution grids (<=06m), due to a known issue of xr.DataArray slice operation (#524 (comment)).However, I feel that it's a wrong decision to disallow
regionfor low-resolution grids, because xr.DataArray slice operation (#524 (comment)) is not commonly used, especially for the GMT's earth relief data, and we havegrdcutto do slice operation.In this PR, we allow
load_earth_relief()function to accept theregionargument for all grid resolutions.Fixes#870.
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version