Skip to content

Dataset "GSHHG Earth distance to shoreline": Update docs and add coastlines to images - #126

Merged
seisman merged 3 commits into
GenericMappingTools:mainfrom
yvonnefroehlich:update-doc-earth-dist
Dec 24, 2024
Merged

Dataset "GSHHG Earth distance to shoreline": Update docs and add coastlines to images#126
seisman merged 3 commits into
GenericMappingTools:mainfrom
yvonnefroehlich:update-doc-earth-dist

Conversation

@yvonnefroehlich

@yvonnefroehlichyvonnefroehlich commented Dec 23, 2024•
edited by seisman
Loading

Copy link
Copy Markdown
Member

Please see comment GenericMappingTools/pygmt#3706 (comment) for context.

Update the documentation for the remote dataset "GSHHG Earth distance to shoreline":

  • Mention distance unit is km
  • Mention distances have both negative and positive values. Positive means land to coastline and negative means ocean to coastline.
  • Add the coastline to the image to make the it more readable.

Preview: https://remote-datasets--126.org.readthedocs.build/en/126/earth-dist.html

seisman
seisman reviewed Dec 24, 2024
View reviewed changes
Comment threadscripts/GMT_earth_maps.sh Outdated
yvonnefroehlichand others added 2 commits December 24, 2024 10:08
@yvonnefroehlich@seisman
Plot only coastlines (no lakes) and use full resolution
d08469f
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@yvonnefroehlich
Update images
f857778
@seisman

seisman commented Dec 24, 2024

Copy link
Copy Markdown
Member

Looks good to me and ping @Esteban82 for review.

@Esteban82

Esteban82 commented Dec 24, 2024•
edited by yvonnefroehlich
Loading

Copy link
Copy Markdown
Member

It looks fine @yvonnefroehlich. Is still a WIP? If not, please remove it from the title.

@yvonnefroehlichyvonnefroehlich changed the title WIP / POC: Udate the docs for dataset "GSHHG Earth distance to shoreline"Udate the docs for dataset "GSHHG Earth distance to shoreline"Dec 24, 2024
@yvonnefroehlichyvonnefroehlich changed the title Udate the docs for dataset "GSHHG Earth distance to shoreline"Dataset "GSHHG Earth distance to shoreline": Update docs and add coastlines to imagesDec 24, 2024
@seisman
seisman merged commit b447dc1 into GenericMappingTools:mainDec 24, 2024
@yvonnefroehlich

yvonnefroehlich commented Dec 24, 2024

Copy link
Copy Markdown
MemberAuthor

It looks fine @yvonnefroehlich. Is still a WIP? If not, please remove it from the title.

This PR should be finished. I updated the title.

@yvonnefroehlich
yvonnefroehlich deleted the update-doc-earth-dist branch December 24, 2024 13:33
@yvonnefroehlichyvonnefroehlich self-assigned this Dec 27, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seismanseismanseisman left review comments
@Esteban82Esteban82Esteban82 approved these changes

Assignees

@yvonnefroehlichyvonnefroehlich

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yvonnefroehlich@seisman@Esteban82