Skip to content

Drop python 2 and make python 3.8 be the minimum. - #275

Closed
schwehr wants to merge 6 commits into
GeospatialPython:masterfrom
schwehr:drop-py2
Closed

Drop python 2 and make python 3.8 be the minimum.#275
schwehr wants to merge 6 commits into
GeospatialPython:masterfrom
schwehr:drop-py2

Conversation

@schwehr

Copy link
Copy Markdown
Contributor

Python 3.7 is end-of-life:

https://devguide.python.org/versions/

https://www.python.org/doc/newstyle/
> New-style classes has been integrated into Python 2.7 and old-style classes has been removed in Python 3.
@schwehrschwehr mentioned this pull request Aug 24, 2024
1 task
This should let me see the workflow run in my work on my fork.
- Still specify the exact python 3.13 as it is not yet released.
- Updated to release candidate 1. 3.13 release is expected in October 2024.
- Also fix the more information link. The old one one is dead.
@schwehr

Copy link
Copy Markdown
ContributorAuthor

Added a bunch more commits and enabled the build.yml workflow on push so I can see the tests run on my branch. All tests work in my branch.

https://github.com/schwehr/pyshp/commits/drop-py2/

@schwehr

Copy link
Copy Markdown
ContributorAuthor

Removing the patch number of the python versions allowing the workflow to pick newer patch levels of particular python versions, e.g., it was 3.8.18, but now 3.8.19 is being used on my latest commit in my drop-py2 branch:

============================= test session starts ==============================
platform linux -- Python 3.8.19, pytest-8.3.2, pluggy-1.[5](https://github.com/schwehr/pyshp/actions/runs/10539369181/job/29202871229#step:6:6).0

@schwehr

Copy link
Copy Markdown
ContributorAuthor

I'm going to close this PR and split things up differently based on some offline discussions.

@schwehrschwehr closed this Aug 28, 2024
@JamesParrottJamesParrott mentioned this pull request Sep 8, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@schwehr