Uh oh!
There was an error while loading. Please reload this page.
JSDK-105 security: remove session token exposure from sdk-java-samples - #24
Merged
Merged
Conversation
ibaca
commented
Jul 14, 2026
Contributor
- Remove sessionChangeHook that logged raw bearer token to stdout on every session rotation
- Remove all session file code: saveSessionFile, loadSessionFile, deleteSessionFile, SESSION_FILE constant, session.local.properties
- Remove sessionId arg — samples no longer accept or cache a session
- newApi() now follows sdk-dotnet-samples pattern exactly: new GeotabApi(...) → authenticate() → return; transparent re-auth on expiry is handled internally by GeotabApi.doCall()
- Add env var support: GEOTAB_SERVER, GEOTAB_DATABASE, GEOTAB_USER, GEOTAB_PASSWORD (checked after system props, before interactive prompt)
- Update README: document three-priority credential resolution, remove session cache docs, add CI/CD usage examples
- Remove sessionChangeHook that logged raw bearer token to stdout on every session rotation - Remove all session file code: saveSessionFile, loadSessionFile, deleteSessionFile, SESSION_FILE constant, session.local.properties - Remove sessionId arg — samples no longer accept or cache a session - newApi() now follows sdk-dotnet-samples pattern exactly: new GeotabApi(...) → authenticate() → return; transparent re-auth on expiry is handled internally by GeotabApi.doCall() - Add env var support: GEOTAB_SERVER, GEOTAB_DATABASE, GEOTAB_USER, GEOTAB_PASSWORD (checked after system props, before interactive prompt) - Update README: document three-priority credential resolution, remove session cache docs, add CI/CD usage examples Co-Authored-By: Claude <noreply@anthropic.com>
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.