Skip to content

feat(Fetcher): fetch_git implementation - #47

Merged
Schille merged 2 commits into
mainfrom
feature/ref-fetch-git
Jul 8, 2022
Merged

feat(Fetcher): fetch_git implementation#47
Schille merged 2 commits into
mainfrom
feature/ref-fetch-git

Conversation

@buschNT

@buschNTbuschNT commented Jul 6, 2022

Copy link
Copy Markdown
Contributor

PR resulting from discussion: #45

@coveralls

coveralls commented Jul 6, 2022•
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 2627934061

  • 15 of 58(25.86%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 64.101%
Changes Missing CoverageCovered LinesChanged/Added Lines%
getdeck/sources/file.py135623.21%
TotalsCoverage Status
Change from base Build 2623395500:-1.1%
Covered Lines:966
Relevant Lines:1507
💛 - Coveralls

@buschNT
feat(Fetcher): support fetching from directory
fb64879
the path of fetch_local and fetch_git can point to a folder
and all yaml files within this folder are parsed
@sonarqubecloud

sonarqubecloudBot commented Jul 7, 2022

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed! Quality Gate passed

BugA0 Bugs
VulnerabilityA0 Vulnerabilities
Security HotspotA0 Security Hotspots
Code SmellA0 Code Smells

No Coverage information No Coverage information
0.0%0.0% Duplication

@buschNT
buschNT marked this pull request as ready for review July 7, 2022 07:49
@buschNT
buschNT requested a review from SchilleJuly 7, 2022 07:50
@buschNTbuschNT self-assigned this Jul 7, 2022
@buschNTbuschNT added the enhancement New feature or request label Jul 7, 2022
@Schille
Schille merged commit 6673a83 into mainJul 8, 2022
@Schille
Schille deleted the feature/ref-fetch-git branch July 8, 2022 07:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SchilleSchilleSchille approved these changes

Assignees

@buschNTbuschNT

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@buschNT@coveralls@Schille