Skip to content

Merge upstream master into GhentAnalysis/master (0.3 release cycle) - #120

Closed
JulesVandenbroeck wants to merge 306 commits into
GhentAnalysis:GhentAnalysis/master_merge_from_upstreamfrom
columnflow:master
Closed

JulesVandenbroeck wants to merge 306 commits into
GhentAnalysis:GhentAnalysis/master_merge_from_upstreamfrom
columnflow:master

Conversation

@JulesVandenbroeck

Copy link
Copy Markdown
Collaborator

Overview

This PR tracks all changes in columnflow/columnflow:master
that are not yet present in GhentAnalysis/master. It is a documentation-only / dummy PR
its purpose is to give an overview of what an eventual merge from upstream would bring in.

The base branch (GhentAnalysis/master_merge_from_upstream) is identical to GhentAnalysis/master
at the time of this PR's creation.


New Features

Framework & Core

Producers & Calibrators

Selectors & Categorization

Histogramming & Plotting

Inference / Datacards

Tasks & Infrastructure


Bug Fixes

Histograms & Plots

  • Hotfix rewriting of outputs in MergeHistograms
  • Hotfix shift id-to-name conversion in histogram post-processing
  • Hotfix empty histogram issue in inference base task (two separate fixes)
  • Hotfix nominal shift in PlotShiftedVariablesPerShift1D
  • Hotfix hist validation in datacard writer
  • Hotfix sci-style axis label notation in plots / fix horizontal y-offset label position
  • Hotfix single shift selection in plotting
  • Hotfix save_div in plot scale factor
  • Hotfix multi-axis filling with discrete variables
  • Bug fix in fill_hist function (bug fix in fill_hist function columnflow/columnflow#768)
  • Fix variance of fake data in datacard writer
  • Fix plotting process shift map (Fix/plotting process shift map columnflow/columnflow#760)
  • Hotfix bad import in plot utils
  • Avoid using flat_np_view for value assignment (Avoid using flat_np_view for value assignment. columnflow/columnflow#759)
  • Use safe concatenation (Use safe concatenation. columnflow/columnflow#758)
  • Hotfix multi-config lookup via patterns
  • Hotfix process object selection for multi-config datacards
  • Hotfix variable shape type in combine datacard writer
  • Fix skipping data in CreateDatacards
  • Hotfix datacard writing when variables are missing in config
  • Hotfix parameter group cleaning in inference model

Producers & Calibrators

  • Hotfix kwargs for array function super calls
  • Hotfix super() calls in all task array functions
  • Hotfix TAF class attribute inheritance and TAF instance method defaults
  • Hotfix calibrator/producer requirement handling
  • Hotfix btag_wp_weights producer: clamp pt and eta efficiency map axes
  • Hotfix ExternalFile dataclass: drop None values
  • Hotfix sorted_ak_to_root helper for nested arrays
  • Hotfix CMS jet veto map usage; correct bit masks (correct bit masks jet veto map columnflow/columnflow#778)
  • Hotfix CMS muon calibrator: remove outdated rnd_gen argument
  • Hotfix abs eta in CMS muon weight producer
  • Hotfix CMS tau energy scale variations
  • [cms] Hotfix varied energy errors in EGM calibration
  • [cms] Hotfix egamma calibrator: use same random numbers for all smearing variations
  • [cms] Hotfix tau energy calibration: skip e-fake mask
  • Hotfix TEC calibrator: add back charge column
  • Hotfix inclusive dataset attribute and lookup in norm weight producer
  • Hotfix norm weight logging
  • Hotfix combined jets calibrator
  • Hotfix validation check in stitched normalization weight production
  • Hotfix missing xsecs for stitched weight producer
  • Hotfix nbtags variable in DY weight producer
  • Fix handling of non_zero_mask in murf_envelope (fix handling of non_zero_mask in murf_envelope columnflow/columnflow#704)
  • Fix JER application on JEC variations (Fix to jer application on jec variations columnflow/columnflow#665)
  • Add exception when era aux is missing (Fix/jec 2023 columnflow/columnflow#700)
  • Fix scope issue in seed producer
  • Hotfix depth limit of gen particles
  • Hotfix saving of columns in gen_particle lookups
  • Hotfix higgs gen lookup: consider effective gluon/photon decays
  • Hotfix typo in gen_top lookup
  • Skip string columns in finiteness checks (Producing string columns columnflow/columnflow#743)

Tasks & Workflow

  • Hotfix task_namespace of Wrapper tasks
  • Hotfix producer group resolution in ProduceColumnsWrapper; fix brace expansion
  • Hotfix config object resolution and order (deterministic and group lookup)
  • Hotfix process selection when only datasets are given
  • Hotfix default version injection into tasks with same family
  • Hotfix version resolution, pinning, and lookup
  • Hotfix forwarding of known_shifts for instance caching
  • Hotfix required producers/calibrators for workflows
  • Hotfix attributes added by TAF decorators
  • Hotfix: allow brace patterns in TAF shifts
  • Fix duplicate producers and requirements
  • Fix workflow parameter passthrough in pilot mode (Fix workflow parameter passthrough in pilot mode. columnflow/columnflow#785)
  • Fix bundle unpacking (Fix ExternalFiles bundle unpacking. columnflow/columnflow#786)
  • Fix total size logged by MergeReductionStats
  • Fix reduction chunk size control
  • Fix task key lookup (Fix task pinning columnflow/columnflow#697)
  • Hotfix requirement order for consistent output removal
  • Hotfix consistent branch reqs between MergeReducedEvents and MergeSelectionStats
  • Raise explicit error in reduction on option type masks

IO & Environment

  • Hotfix ChunkedParquetReader
  • Multiple fixes regarding empty files or almost-empty chunks (mutliple fixes regarding empty files or (almost) empty chunks columnflow/columnflow#750)
  • Hotfix reduction to skip empty chunks
  • Fix mamba setup
  • Hotfix htcondor/conda software setup in remote jobs
  • Fix missing datasets in MultiConfig
  • Hotfix CAT metadata update check for missing POG dirs
  • Hotfix category flattening
  • Correct JSON file extension for stats file
  • Do not consider empty axis as "missing" (histogram axis fix)
  • Fix opening root files in cf_inspect / after coffea update (Fix cf_inspect script after coffea update. columnflow/columnflow#753)
  • Log broken parquet file paths
  • Fix warning message in BundleExternalFiles task
  • Hotfix repo bundling: add missing user config
  • Failsafe setting of htcondor requested memory
  • Apply blinding threshold before process scaling
  • Hotfix electron weight producer with nested working points

Small Changes

Dependency & Submodule Updates

  • Multiple law, order, scinum, and boost-histogram submodule/version updates
  • Update default CMSSW versions in CMSSW sandboxes

Code Quality & Cleanup

  • Multiple typo fixes across the codebase
  • Minor code cleanups and consistency changes
  • Cleanup of e/mu id producers; remove unneeded columns in CMS TEC calibrator
  • Consistent handling of kwargs in teardown functions
  • Improve treepath detection in cf_inspect; optimize UniteColumns ROOT compression
  • Improve tmp file check and flag file handling in venv setup
  • Use return code in cf_remove_tmp; add local directory check
  • [cms] Add note on TEC-to-MET propagation
  • Store jec level as attribute on jec correctors
  • Bump version in __version__ file
  • Improve readability of make_jme_keys

Logging & Verbosity

  • More verbose errors for parquet metadata failures, norm weight missing cross sections, memory issues during filling, and broken histogram files
  • Warn about flow content for FlowStrategy.move
  • [cms] Update log in CheckCATUpdates task; add URL to log

Documentation

  • docs: add LennertGriesing, Lara813, aalvesan, Bogdan-Wiederspan, LuSchaller as contributors

Tests

  • Adjust unit tests for new behaviour and deterministic config object ordering

This PR was auto-generated to track upstream changes. It is not intended to be merged directly.

mafrahm and others added 30 commits July 29, 2025 14:05
* update met_phi Calibrator to new format

* use npvsGood

* add npvsGood to uses as well...

* Minor adjustments, apply mask to all inputs.

---------

Co-authored-by: Mathis Frahm <mathis.frahm@uni-hamburg.de>
Co-authored-by: Marcel R. <github.riga@icloud.com>
* Generalize normalization weight producer.

* Add pull warning.

* Add per-dataset weight norm.

* Update.

* Optionally log brs.

* Improve combinatoric treatment, fix single br calculation.

* Helper to fill weight table.

* Minor adjustments before review.
Co-authored-by: Mathis Frahm <mathis.frahm@uni-hamburg.de>
Co-authored-by: Marcel Rieger <riga@users.noreply.github.com>
riga and others added 29 commits April 13, 2026 11:28
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants