Uh oh!
There was an error while loading. Please reload this page.
fix: serialize pydantic request bodies before passing to httpx json= - #2
Open
MCPVOT wants to merge 1 commit into
Open
fix: serialize pydantic request bodies before passing to httpx json=#2MCPVOT wants to merge 1 commit into
MCPVOT wants to merge 1 commit into
Conversation
Generated service methods pass typed request DTOs (pydantic BaseModel) straight
to httpx json=, which cannot serialize them (TypeError: not JSON serializable)
— every typed POST/PUT method crashed before reaching the network. Only plain
dicts worked.
Add serialize_payload() to request_utils (model_dump(exclude_none=True), with
recursive handling for dicts/lists), and wrap the 291 call sites across 42
service files. Dicts and primitives pass through unchanged; None stays None.
Verified: py_compile clean on all files; serialize_payload(CreateContactDtoV3)
produces a JSON-serializable dict with the exact proven customFields shape
({key, fieldValue}); edge cases (None, dict, nested list) pass.There was a problem hiding this comment.
Orca Security Scan Summary
| Status | Check | Issues by priority | |
|---|---|---|---|
 Passed | Infrastructure as Code |  0  0  0  0 | View in Orca |
| Passed | SAST | 0 0 0 0 | View in Orca |
| Passed | Secrets | 0 0 0 0 | View in Orca |
| Passed | Vulnerabilities | 0 0 0 0 | View in Orca |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Generated service methods pass typed request DTOs (pydantic BaseModel) straight to httpx
json=. httpx uses plain json.dumps (no default=), which cannot serialize BaseModel — every typed POST/PUT method (create_contact, update_contact, upsert_contact, create_note, add_tags, ...) crashes with TypeError before reaching the network. Only plain-dict bodies work.Fix
serialize_payload()insrc/highlevel/utils/request_utils.py:model_dump(exclude_none=True)for BaseModel, recursive for dict/list, passthrough for primitives, None stays None.Verification
Impact
Unblocks every typed-body method in the SDK (the most common usage per the README). ~10 lines of real logic in one place.