fix: Idempotent start

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.

[plajdo]

Added check whether any subscriptions for current Reactor are active. This makes start function idempotent for callers, and effectively prevents creating duplicate subscriptions.

Condition: transform function must be free of side effects, as empty transform will be called multiple times, until first subscription is created for the Reactor.

---

Disabled auto-start of AnyReactor type-erased type.
Previously this auto-start behaviour caused incorrectly stored Combine/non-combine subscriptions to external events from viewModels. Subscriptions were being stored under the wrapper type, which caused confusion and non-clear event routing.

Added tests to verify.

---

Effects:

Call to viewModel.start() now has to be explicit and will always be forwarded to correct concrete Reactor type.

[andrej-jasso]

Reviewed and verified locally:

• Full test suite passes (24 tests, 0 failures), including the new idempotency tests.
• The start() guard is race-free on the main actor: makeCombineEventStream() itself stores a subscription synchronously, so repeated start() calls bail out even for reactors with an empty transform().
• Note: removing auto-start from AnyReactor.init is a behavior change for existing users — documented in README, but worth calling out in the next release notes.