[BEAM-222] Backport BEAM pull/235

[mshields822]

No description provided.

[mshields822]

R: @davorbonaci

Note this will break sdk.runners.worker. WorkerCustomSourcesTest

[mshields822]

Revised to also track BEAM pull/248

[davorbonaci]

LGTM, from my perspective.

However, @dhalperi has merged Beam changes -- he should take a final look and merge.

[dhalperi]

It looks like this is a backport of:

• Make BoundedReadFromUnboundedSourceTest work across runners apache/beam#132
• [BEAM-222] Respect checkpointing contract in TestCountingSource apache/beam#235
• [BEAM-222] Don't advance beyond last valid value apache/beam#248

Is that right, Mark?

It looks like some of the changes in 132 are missing. Intentional?

[mshields822]

I kept the new sharding option in TestCountingSource for simplicity of
backporting. I did not backport the BoundedReadFromUnboundedSourceTest
changes.

On Tue, Apr 26, 2016 at 11:45 PM, Daniel Halperin notifications@github.com
wrote:

It looks like this is a backport of:

• Make BoundedReadFromUnboundedSourceTest work across runners apache/beam#132
  Make BoundedReadFromUnboundedSourceTest work across runners apache/beam#132
• [BEAM-222] Respect checkpointing contract in TestCountingSource apache/beam#235
  [BEAM-222] Respect checkpointing contract in TestCountingSource apache/beam#235
• [BEAM-222] Don't advance beyond last valid value apache/beam#248
  [BEAM-222] Don't advance beyond last valid value apache/beam#248

Is that right, Mark?

It looks like some of the changes in 132 are missing. Intentional?

—
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#217 (comment)