Uh oh!
There was an error while loading. Please reload this page.
Fix undefined property bug - #634
Conversation
chanseokoh
commented
May 2, 2018
I'll fix the test. |
lukecwik
commented
May 3, 2018
@huygaa11 Should this be merged back into Apache Beam? |
chanseokoh
commented
May 7, 2018
ping |
huygaa11
commented
May 7, 2018
@lukecwik yes, I can do that in a consequent PR. |
huygaa11
commented
May 7, 2018
@chanseokoh If you would like to contribute to Beam, feel free to send a PR to beam repo. Let me know if you are interested :). Here is the file in Beam: |
chanseokoh
commented
May 7, 2018
@huygaa11 sure, let me do that. |
chanseokoh
commented
May 7, 2018
@huygaa11 there's some gradle stuff that I don't understand, so I'll just create a new issue and leave it to you. |
huygaa11
commented
May 7, 2018
No worries. Thanks for looking into it. |
chanseokoh
commented
May 7, 2018
On the Beam repo, I find
I wonder if they should be Do note that you'll find a lot of instances of |
lukecwik
commented
May 10, 2018
Sure, swapping so the property name better aligns with the name of the plugin makes sense. |
Fixes#633.