Uh oh!
There was an error while loading. Please reload this page.
Minimize setTimeout delays in tests - #137
Conversation
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
rakyll
commented
Aug 27, 2014
Could you lint your code? Use |
ryanseys
commented
Aug 27, 2014
ryanseys
commented
Aug 27, 2014
Should be good to go? |
stephenplusplus
commented
Aug 27, 2014
Can you rebase against master, then squash? I think you've got an extra merge commit tagging along. |
ryanseys
commented
Aug 27, 2014
Yeah I screwed up and didn't do this on a separate branch so I'll see what I can do... these are the dark sides of git I don't yet fully understand. |
ryanseys
commented
Aug 27, 2014
Wow, first try! Sometimes I amaze myself. How's that look? |
stephenplusplus
commented
Aug 27, 2014
Git: Every time you think you've found your way out, there's another dark alley waiting for you. ™️ 🔦 If it helps, my process is usually: $ git checkout -b feature origin/master
# commit a bunch of work
$ git fetch origin
$ git rebase origin/master
# push to my remoteThe key part being the rebase, which picks up your changes, syncs up with master, then plops your changes back down on top of them. |
stephenplusplus
commented
Aug 27, 2014
It's perfect! Thanks 👯 |
Minimize setTimeout delays in tests
🤖 I have created a release \*beep\* \*boop\* --- ### [1.4.6](https://www.github.com/googleapis/nodejs-memcache/compare/v1.4.5...v1.4.6) (2021-07-21) ### Bug Fixes * Updating WORKSPACE files to use the newest version of the Typescript generator. ([#136](https://www.github.com/googleapis/nodejs-memcache/issues/136)) ([619f23e](https://www.github.com/googleapis/nodejs-memcache/commit/619f23ec0c25c8e5dd97894ada5f65ae763d2721)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
…andwritten libraries (#137) - [ ] Regenerate this pull request now. PiperOrigin-RevId: 429395631 Source-Link: googleapis/googleapis@84594b3 Source-Link: googleapis/googleapis-gen@ed74f97 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWQ3NGY5NzBmZDgyOTE0ODc0ZTZiMjdiMDQ3NjNjZmE2NmJhZmU5YiJ9

Mocha was giving warnings that a few tests were running slowly. In both cases, the reason was that there was a
setTimeoutrunning a few callbacks under a significant delay. I reduced the time to 1ms and tests still passed so I don't see why the delay was necessary. If the delay is necessary, perhaps these tests should be failing under the new conditions I've set.If someone can shed some light on why the callbacks are called under a
setTimeoutin the first place, that would also help me out.