Uh oh!
There was an error while loading. Please reload this page.
tests: connection refactor. - #148
Merged
Merged
Conversation
ryanseys
commented
Aug 28, 2014
Contributor
Events! 👍 This means no more counting |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
stephenplusplusforce-pushed
the
connection-tests
branch
from
August 29, 2014 20:24
33f021d to
b91ad63Comparerakyll
commented
Aug 29, 2014
Contributor
This is great, merging. |
This was referenced Jul 21, 2021
chingor13 pushed a commit
that referenced
this pull request
Aug 22, 2022
4 tasks
4 tasks
sofisl pushed a commit
that referenced
this pull request
Sep 16, 2022
sofisl pushed a commit
that referenced
this pull request
Oct 5, 2022
This was referenced Oct 5, 2022
sofisl pushed a commit
that referenced
this pull request
Oct 8, 2022
This was referenced Oct 11, 2022
sofisl pushed a commit
that referenced
this pull request
Oct 12, 2022
* build: check dead links on Kokoro * recursive crawl local links * fix docs * fix bad timestamp links * fix excludes
sofisl pushed a commit
that referenced
this pull request
Oct 12, 2022
This was referenced Oct 12, 2022
This was referenced Jan 27, 2026
sofisl pushed a commit
that referenced
this pull request
Jan 27, 2026
fix: stop recording samples with time profile
This was referenced Jan 27, 2026
miguelvelezsa pushed a commit
that referenced
this pull request
Jan 28, 2026
This was referenced Jan 29, 2026
GautamSharda pushed a commit
that referenced
this pull request
Feb 2, 2026
This was referenced Feb 3, 2026
4 tasks
4 tasks
4 tasks
4 tasks
This was referenced Feb 26, 2026
4 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hitching off what @ryanseys found in #137 and the discussion that followed, here's a bit of a refactoring of the queue behavior of connection. Instead of building our own, we can use the NodeWay:tm: with the built in event emitter.
I was also able to hopefully simplify some of the setting up of Connection instances in the test.