Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Apr 25, 2022. It is now read-only.
Updating README to make EXTRA_TOX_ENVS public. [ci skip] - #3
Merged
Conversation
dhermes
commented
Oct 29, 2014
ContributorAuthor
I added |
tseaver
commented
Oct 29, 2014
I don't know enough about the semantics of '--public' to verify here. |
dhermes
commented
Oct 30, 2014
ContributorAuthor
|
dhermes
commented
Nov 6, 2014
ContributorAuthor
@silvolu Can you give this a look? |
silvolu
commented
Nov 6, 2014
Contributor
You want to make the value visible in the build report and the settings right? If that's the case, LGTM. |
dhermes
commented
Nov 6, 2014
ContributorAuthor
Yeah. The logic being that this will change more often than the others and a maintainer may forget the value. It depends on the |
dhermes added a commit
that referenced
this pull request
Nov 6, 2014
Updating README to make EXTRA_TOX_ENVS public. [ci skip]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@tseaver PTAL. This is to agree with googleapis/google-cloud-python#309