Uh oh!
There was an error while loading. Please reload this page.
Making yaml files templates, updating readme and makefile. - #18
Merged
Conversation
waprin
commented
Jan 7, 2016
Contributor
Hmm I had actually done it this way for Django then changed it to one file. I think it's simpler to just have one file, the typical user changes it once on their end and then they're done. With the template files ehre I like how your |
theacodes
commented
Jan 7, 2016
Author
I can leave it as one file, that's fine. I agree we should be consistent - we should have |
theacodesforce-pushed
the
kubernetes-updates
branch
from
January 7, 2016 17:51
29e0a00 to
ec7aceeComparetheacodes
commented
Jan 7, 2016
Author
Updated, take another look when you get a chance. |
waprin
commented
Jan 21, 2016
Contributor
lgtm |
theacodes pushed a commit
that referenced
this pull request
Jan 21, 2016
Making yaml files templates, updating readme and makefile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.