Uh oh!
There was an error while loading. Please reload this page.
Use PEP8 names in test helper methods - #2710
Conversation
@dhermes was this scripted at all? Also, my internet may be slow or something but I can't even get the files view to load ATM. |
dhermes
commented
Nov 9, 2016
It's probably not your internet, just the browser failing because of too much memory needed. May be easier to check out my branch locally.
See my comment |
daspecster
commented
Nov 9, 2016
@dhermes oh I didn't expand the commit messages. That's cool. |
daspecster
commented
Nov 9, 2016
What would it take to enable We could just update the regex that |
daspecster
commented
Nov 9, 2016
Also this LGTM after the rebase and travs going green. |
dhermes
commented
Nov 10, 2016
I'd imagine a lot. We could probably get some mileage out of tweaking regexes. |
Done via: $ git grep -l 'def _getTargetClass(self)' | \ > xargs sed -i s/'def _getTargetClass(self)'/'@staticmethod\n def _get_target_class()'/g
Done via: $ git grep -l _getTargetClass | \ > xargs sed -i s/_getTargetClass/_get_target_class/g
Done via: $ git grep -l _makeOne | \ > xargs sed -i s/_makeOne/_make_one/g
Done via: $ git grep -l _callFUT | \ > xargs sed -i s/_callFUT/_call_fut/g
34b1e17 to
affb4a3Comparedhermes
commented
Nov 10, 2016
Just rebased. Will merge if/when at least one CI goes green. |
Use PEP8 names in test helper methods
Use PEP8 names in test helper methods
Use PEP8 names in test helper methods
Use PEP8 names in test helper methods
From discussion with @tseaver in #2681
Most of this PR was created from the command line, see the commit messages for the commands used to create the commits.
I also wanted to turn off the
no-self-usedisable in the test Pylint RC but it had too many offenders left to put in this PR.