Adding system test to exercise all possible Spanner types. by dhermes · Pull Request #3384 · googleapis/google-cloud-python

dhermes · 2017-05-08T20:05:16Z

In the process, changing how +/- Infinity are sent to the backend (this was a bug).

/cc @vkedia It's worth noting that Value(string_value='inf') / Value(string_value='+inf') / Value(string_value='-inf') are being rejected, but should probably be accepted when Type.code == FLOAT64.

dhermes · 2017-05-08T22:06:47Z

Just created this branch on the GCP remote so that we'd get a build with system tests

vkedia · 2017-05-08T22:38:36Z

@dhermes It has to be "Infinity" and "-Infinity"

Sign in to view

- def _list_instances():
- return list(Config.CLIENT.list_instances())
-
 instances = retry(_list_instances)()


Sign in to view

- for found, expected in zip(row_data, self.ROW_DATA):
+ def _assert_timestamp(self, value, nano_value):
+ self.assertIsInstance(value, datetime.datetime)
+ self.assertIn(value.tzinfo, (None, UTC))


Sign in to view

+ self.assertEqual(value.minute, nano_value.minute)
+ self.assertEqual(value.second, nano_value.second)
+ self.assertEqual(value.microsecond, nano_value.microsecond)
+ if isinstance(value, TimestampWithNanoseconds):


Sign in to view

- yield [index, 'First%09d' % (index,), 'Last09%d' % (index),
- 'test-%09d@example.com' % (index,)]
-
 keyset = KeySet(all_=True)


dhermes · 2017-05-08T22:53:55Z

It has to be "Infinity" and "-Infinity"

@vkedia I realize that now (made the necessary change in this PR). I'm suggesting that you also accept inf/ +inf / -inf.

tseaver · 2017-05-08T23:10:01Z

@dhermes The principle you were trying to name in today's call is Postel's Law:

An implementation should be conservative in its sending behavior, and liberal in its receiving behavior

dhermes · 2017-05-09T20:00:21Z

@tseaver We good to merge this?

tseaver · 2017-05-09T20:06:08Z

Ugh, I screwed up merging mine first.

dhermes · 2017-05-09T20:07:55Z

I'll fix it.

googlebot · 2017-05-09T20:09:55Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

tseaver · 2017-05-09T20:10:19Z

I just tweaked it here. Feel free to back out my change.

Also used our GrpcRendezvous alias for _Rendezvous and making some "conditionally defined" functions into a module-level function and a test case staticmethod.

tseaver · 2017-05-09T20:12:13Z

And merge when green.

In the process, changing how +/- Infinity are sent to the backend (this was a bug). Fixesgoogleapis#3016.

googlebot · 2017-05-09T20:16:06Z

CLAs look good, thanks!

dhermes · 2017-05-09T20:16:40Z

Ah sorry, just did a force push before seeing your comment.

tseaver · 2017-05-09T20:19:03Z

No worries.

dhermes · 2017-05-09T20:25:10Z

Will wait on build on the GCP remote: https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/1785

tseaver · 2017-05-09T20:26:06Z

Green on CircleCI.

* Spanner test hygiene: move fixtures out of distro. Also used our GrpcRendezvous alias for _Rendezvous and making some "conditionally defined" functions into a module-level function and a test case staticmethod. * Adding system test to exercise all possible Spanner types. In the process, changing how +/- Infinity are sent to the backend (this was a bug). Fixes#3016.

dhermes added api: spanner Issues related to the Spanner API. testing labels May 8, 2017

dhermes assigned lukesneeringer and tseaver May 8, 2017

googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2017

tseaver mentioned this pull request May 8, 2017
Add system test for Database convenience methods: #3385
Merged

tseaver reviewed May 8, 2017
View reviewed changes

googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels May 9, 2017

Spanner test hygiene: move fixtures out of distro.
8ebd039
Also used our GrpcRendezvous alias for _Rendezvous and making some "conditionally defined" functions into a module-level function and a test case staticmethod.

Adding system test to exercise all possible Spanner types.
71da36f
In the process, changing how +/- Infinity are sent to the backend (this was a bug). Fixesgoogleapis#3016.

dhermes force-pushed the fix-3016 branch from 73748b4 to 71da36fCompare May 9, 2017 20:16

googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels May 9, 2017

dhermes merged commit 391c6fd into googleapis:masterMay 9, 2017

dhermes deleted the fix-3016 branch May 9, 2017 20:30

Uh oh!

Conversation

dhermes commented May 8, 2017

Uh oh!

dhermes commented May 8, 2017

Uh oh!

vkedia commented May 8, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

dhermes commented May 8, 2017

Uh oh!

tseaver commented May 8, 2017

Uh oh!

dhermes commented May 9, 2017

Uh oh!

tseaver commented May 9, 2017

Uh oh!

dhermes commented May 9, 2017

Uh oh!

googlebot commented May 9, 2017

Uh oh!

tseaver commented May 9, 2017

Uh oh!

tseaver commented May 9, 2017

Uh oh!

googlebot commented May 9, 2017

Uh oh!

dhermes commented May 9, 2017

Uh oh!

tseaver commented May 9, 2017

Uh oh!

dhermes commented May 9, 2017

Uh oh!

tseaver commented May 9, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants