Skip to content

Add system test for Database convenience methods: - #3385

Merged
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:3015-spanner-convnience_wrapper_systests
May 9, 2017
Merged

Add system test for Database convenience methods:#3385
tseaver merged 1 commit into
googleapis:masterfrom
tseaver:3015-spanner-convnience_wrapper_systests

Conversation

@tseaver

@tseavertseaver commented May 8, 2017

Copy link
Copy Markdown
Contributor
  • batch
  • snapshot
  • read
  • run_with_transaction
  • execute_sql

Closes#3015.

@tseavertseaver added api: spanner Issues related to the Spanner API. release blocking Required feature/issue must be fixed prior to next release. testing labels May 8, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 8, 2017
dhermes
dhermes reviewed May 8, 2017
View reviewed changes

@dhermesdhermes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine

Comment threadspanner/tests/system.py Outdated
self.assertEqual(len(temp_db.ddl_statements), len(DDL_STATEMENTS))

def test_db_batch_insert_then_db_snapshot_read_and_db_read(self):
from google.cloud.spanner import KeySet

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadspanner/tests/system.py Outdated

def test_db_batch_insert_then_db_snapshot_read_and_db_read(self):
from google.cloud.spanner import KeySet
keyset = KeySet(all_=True)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadspanner/tests/system.py Outdated
retry(self._db.reload)()

with self._db.batch() as batch:
batch.delete(self.TABLE, keyset)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

Comment threadspanner/tests/system.py Outdated
batch.insert(self.TABLE, self.COLUMNS, self.ROW_DATA)

with self._db.snapshot(read_timestamp=batch.committed) as snapshot:
from_snap = list(snapshot.read( self.TABLE, self.COLUMNS, keyset))

This comment was marked as spam.

Sign in to view

Comment threadspanner/tests/system.py
with self._db.batch() as batch:
batch.delete(self.TABLE, keyset)

def _unit_of_work(transaction, test):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver

tseaver commented May 8, 2017

Copy link
Copy Markdown
ContributorAuthor

Should I follow suit and push the updated branch to the origin to get a build with system tests? We could close this PR and re-open there.

@tseaver
Add system test for Database convenience methods:
036dd41
- batch
- snapshot
- read
- run_with_transaction
- execute_sql
Closes#3015.
@dhermes

dhermes commented May 8, 2017

Copy link
Copy Markdown
Contributor

@tseaver Yes I think you should push this branch to the GCP origin to get system tests running. You don't need to close this PR though, the tests will "just work" (i.e. be associated here).

@tseaver

tseaver commented May 8, 2017

Copy link
Copy Markdown
ContributorAuthor

Pushed to upstream.

@tseaver

tseaver commented May 9, 2017

Copy link
Copy Markdown
ContributorAuthor

@dhermes New system tests pass on CI. Any further issues?

@dhermes

dhermes commented May 9, 2017

Copy link
Copy Markdown
Contributor

LGTM

@tseaver
tseaver merged commit 19315e0 into googleapis:masterMay 9, 2017
@tseaver
tseaver deleted the 3015-spanner-convnience_wrapper_systests branch May 9, 2017 20:05
parthea pushed a commit that referenced this pull request Sep 22, 2023
@nnegrey@danoscarmike
video: use flaky on flaky timeouts [(#3385)](GoogleCloudPlatform/pyth…
e25af18
…on-docs-samples#3385)
* video: use flaky on flaky timeouts
* Update beta_snippets_test.py
* remove api result check
* Update beta_snippets_test.py
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukesneeringerlukesneeringerAwaiting requested review from lukesneeringer
1 more reviewer
@dhermesdhermesdhermes left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: spannerIssues related to the Spanner API.cla: yesThis human has signed the Contributor License Agreement.release blockingRequired feature/issue must be fixed prior to next release.testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver@dhermes@googlebot