Skip to content

Remove basePath: "/" - #1076

Closed
navinger wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
navinger:patch-4
Closed

Remove basePath: "/"#1076
navinger wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
navinger:patch-4

Conversation

@navinger

Copy link
Copy Markdown
Contributor

I'm updating all the openapi files in the getting-started sample in all the sample repos to remove basePath: "/"
Here's the reason from simonz130:

From the OpenAPI 2 spec:

  • basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). "
  • Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL."

This OpenAPI getting-started sample have basePath: "/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.

I'm updating all the openapi files in the getting-started sample in all the sample repos to remove basePath: "/"
Here's the reason from simonz130:
From the OpenAPI 2 spec:
* basePath: "If it is not included, the API is served directly under the host. The value MUST start with a leading slash (/). "
* Paths for methods: "A relative path to an individual endpoint. The field name MUST begin with a slash. The path is appended to the basePath in order to construct the full URL."
This OpenAPI getting-started sample have basePath: "/", which (per strict spec interpretation) means all the paths start with double-slashes. (e.g "//v1/shelves" rather than "/v1/shelves"). Removing basepath="/" fixes that.
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 29, 2018
@lesv

lesv commented Mar 29, 2018

Copy link
Copy Markdown
Contributor
- testing endpoints/getting-started
------------------------------------------------------------
[ERROR] src/main/java/com/example/endpoints/AuthInfoServlet.java:[1] (header) RegexpHeader: Line does not match expected header line of '^\W+\*?\W*Copyright 20\d\d Google Inc.$'.
[ERROR] src/main/java/com/example/endpoints/EchoServlet.java:[1] (header) RegexpHeader: Line does not match expected header line of '^\W+\*?\W*Copyright 20\d\d Google Inc.$'.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default) on project endpoints: You have 2 Checkstyle violations. -> [Help 1]

@lesv

lesv commented Mar 29, 2018

Copy link
Copy Markdown
Contributor

@dzlier-gcp Could you fix this for Nancy and the other one?
@kurtisvg I looked at the header and don't see what's wrong.

@kurtisvg

Copy link
Copy Markdown
Contributor

I'm going to merge this into #1077.

Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
…#1076)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/compatibility-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/confidence-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12)
##### Dependencies
- Update dependency com.google.api:gax-bom to v2.19.1 ([#&#8203;915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29))
- Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#&#8203;916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
…1076)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.5` -> `2.5.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/compatibility-slim/2.5.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/confidence-slim/2.5.5)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.5.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;256-httpsgithubcomgoogleapisjava-corecomparev255v256-2022-03-01)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.5...v2.5.6)
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…#1076)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/compatibility-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/confidence-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12)
##### Dependencies
- Update dependency com.google.api:gax-bom to v2.19.1 ([#&#8203;915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29))
- Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#&#8203;916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…#1076)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/compatibility-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/confidence-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12)
##### Dependencies
- Update dependency com.google.api:gax-bom to v2.19.1 ([#&#8203;915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29))
- Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#&#8203;916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
…1076)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.5` -> `2.5.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/compatibility-slim/2.5.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/confidence-slim/2.5.5)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.5.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;256-httpsgithubcomgoogleapisjava-corecomparev255v256-2022-03-01)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.5...v2.5.6)
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
…#1076)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.11` -> `2.8.12` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/compatibility-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.12/confidence-slim/2.8.11)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.12`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;2812-httpsgithubcomgoogleapisjava-corecomparev2811v2812-2022-09-14)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.11...v2.8.12)
##### Dependencies
- Update dependency com.google.api:gax-bom to v2.19.1 ([#&#8203;915](https://togithub.com/googleapis/java-core/issues/915)) ([2647fde](https://togithub.com/googleapis/java-core/commit/2647fdee8e2b168f3364af8e76abfe2903578b29))
- Update dependency com.google.protobuf:protobuf-bom to v3.21.6 ([#&#8203;916](https://togithub.com/googleapis/java-core/issues/916)) ([a7db234](https://togithub.com/googleapis/java-core/commit/a7db234800481ffba71d3222542971dbcd212d8e))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-translate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xOTUuNSIsInVwZGF0ZWRJblZlciI6IjMyLjE5Ny4wIn0=-->
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
…1076)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.5.5` -> `2.5.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/compatibility-slim/2.5.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.5.6/confidence-slim/2.5.5)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.5.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;256-httpsgithubcomgoogleapisjava-corecomparev255v256-2022-03-01)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.5.5...v2.5.6)
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@navinger@lesv@kurtisvg@googlebot