Skip to content

Remove unused dependency region tags and update used region tags - #1197

Merged
tswast merged 2 commits into
masterfrom
update-dependency-tags
Aug 29, 2018
Merged

Remove unused dependency region tags and update used region tags#1197
tswast merged 2 commits into
masterfrom
update-dependency-tags

Conversation

@alixhami

@alixhamialixhami commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

The goal with sample region tags is to have a globally unique tag for each sample. The "dependencies" tag is used throughout the java-docs-samples repo, which goes against best practices. This PR accomplishes the following:

  • For region tags that are not used on cloud.google.com, remove the region tag
  • For region tags that are used on cloud.google.com, add a prefix of product_java_ (ex. bigquery_java_dependencies)

Note that this PR does not include all products, only ones that I am responsible for adding to the sample tracker. Others will be performing this update for the remaining products.

@alixhami
alixhami requested review from nnegrey and tswastAugust 27, 2018 21:38
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2018
nnegrey
nnegrey previously approved these changes Aug 27, 2018
View reviewed changes

@nnegreynnegrey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(interesting how some are used and others aren't)

@nnegreynnegrey added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 27, 2018
tswast
tswast previously approved these changes Aug 28, 2018
View reviewed changes
@alixhami
alixhami dismissed stale reviews from tswast and nnegrey via 97329cdAugust 28, 2018 21:28
@alixhami
alixhamiforce-pushed the update-dependency-tags branch from 5e63c84 to 97329cdCompareAugust 28, 2018 21:28
@alixhami

alixhami commented Aug 28, 2018

Copy link
Copy Markdown
ContributorAuthor

I updated my approach with the unused region tags. Rather than deleting them, I gave them names that use the standard globally unique naming conventions, so that we avoid people adding the plain "dependencies" region tag in the future.

@alixhami
alixhamiforce-pushed the update-dependency-tags branch from 97329cd to 4669400CompareAugust 29, 2018 00:38
tswast
tswast previously approved these changes Aug 29, 2018
View reviewed changes
@nnegreynnegrey added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2018
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 29, 2018
@alixhamialixhami changed the title [Do not merge] Remove unused dependency region tags and update used region tagsRemove unused dependency region tags and update used region tagsAug 29, 2018
@alixhamialixhami removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 29, 2018
@alixhami
alixhamiforce-pushed the update-dependency-tags branch from 4669400 to 2f10893CompareAugust 29, 2018 19:32
@tswast
tswast merged commit a88e2ff into masterAug 29, 2018
@alixhami
alixhami deleted the update-dependency-tags branch August 29, 2018 20:00
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-core to v2.8.6 (#…
ff0cbc0
…1197)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/compatibility-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/confidence-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.5...v2.8.6)
##### Dependencies
- update dependency com.google.api:gax-bom to v2.18.7 ([#&#8203;890](https://togithub.com/googleapis/java-core/issues/890)) ([c67bed5](https://togithub.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7))
- update dependency com.google.code.gson:gson to v2.9.1 ([#&#8203;888](https://togithub.com/googleapis/java-core/issues/888)) ([7b799c6](https://togithub.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
@ShabirmeanShabirmean mentioned this pull request Nov 17, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
@renovate-bot@Shabirmean
deps: update dependency com.google.cloud:google-cloud-core to v2.8.6 (#…
9232e88
…1197)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/compatibility-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/confidence-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.5...v2.8.6)
##### Dependencies
- update dependency com.google.api:gax-bom to v2.18.7 ([#&#8203;890](https://togithub.com/googleapis/java-core/issues/890)) ([c67bed5](https://togithub.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7))
- update dependency com.google.code.gson:gson to v2.9.1 ([#&#8203;888](https://togithub.com/googleapis/java-core/issues/888)) ([7b799c6](https://togithub.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
@renovate-bot@anguillanneuf
deps: update dependency com.google.cloud:google-cloud-core to v2.8.6 (#…
294617b
…1197)
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.5` -> `2.8.6` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/compatibility-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-core/2.8.6/confidence-slim/2.8.5)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>googleapis/java-core</summary>
### [`v2.8.6`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#&#8203;286-httpsgithubcomgoogleapisjava-corecomparev285v286-2022-08-02)
[Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.5...v2.8.6)
##### Dependencies
- update dependency com.google.api:gax-bom to v2.18.7 ([#&#8203;890](https://togithub.com/googleapis/java-core/issues/890)) ([c67bed5](https://togithub.com/googleapis/java-core/commit/c67bed5281b458e78780cdd918235b5d073917c7))
- update dependency com.google.code.gson:gson to v2.9.1 ([#&#8203;888](https://togithub.com/googleapis/java-core/issues/888)) ([7b799c6](https://togithub.com/googleapis/java-core/commit/7b799c66f4aaf057242e9a231b920e49a7c964e9))
</details>
---
### Configuration
📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast left review comments
+1 more reviewer
@nnegreynnegreynnegrey left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alixhami@tswast@nnegrey@googlebot@kokoro-team