Uh oh!
There was an error while loading. Please reload this page.
Update to use shared data bucket for import test in Product Search - #1303
Closed
nirupa-kumar wants to merge 9 commits into
Closed
Update to use shared data bucket for import test in Product Search#1303nirupa-kumar wants to merge 9 commits into
nirupa-kumar wants to merge 9 commits into
Conversation
nirupa-kumar
commented
Dec 20, 2018
ContributorAuthor
@nnegrey |
dzlier-gcp
previously approved these changes
Jan 10, 2019
dzlier-gcp
commented
Jan 10, 2019
Member
I just updated this to match master branch, and the tests now fail consistently. Please review the test logs. |
kurtisvg
commented
Feb 8, 2019
Contributor
@nirupa-kumar@nnegrey PTAL at the tests |
nirupa-kumar
commented
Feb 8, 2019
ContributorAuthor
working on trying to fix the flakiness. |
kurtisvg
commented
Jun 11, 2019
Contributor
@nnegrey Is this PR still needed or can we close it out? |
nnegrey
commented
Jun 12, 2019
Contributor
Oh gosh, um I should probably pick this up. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.