Skip to content

Endpoints Auth Between Services - #1330

Merged
daniel-sanche merged 15 commits into
GoogleCloudPlatform:masterfrom
daniel-sanche:endpoints-auth
Feb 8, 2019
Merged

Endpoints Auth Between Services#1330
daniel-sanche merged 15 commits into
GoogleCloudPlatform:masterfrom
daniel-sanche:endpoints-auth

Conversation

@daniel-sanche

@daniel-sanchedaniel-sanche commented Feb 7, 2019

Copy link
Copy Markdown
Member

Adding java samples for endpoints auth between services

related to b/109951097 and cl/228405078

@daniel-sanche
daniel-sanche requested a review from a teamFebruary 7, 2019 01:31
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 7, 2019
kurtisvg
kurtisvg suggested changes Feb 8, 2019
View reviewed changes

@kurtisvgkurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are also likely several style violations that checkstyle will check when the parent pom is added.

Comment threadendpoints/getting-started/clients/pom.xml
Comment threadendpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
Comment threadendpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
Comment threadendpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
Comment threadendpoints/getting-started/clients/src/main/java/com/example/app/JWTClient.java Outdated
@daniel-sanche

daniel-sanche commented Feb 8, 2019

Copy link
Copy Markdown
MemberAuthor

@kurtisvg I addressed your comments, let me know if there's anything else

@kurtisvg

kurtisvg commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

@dansanche Just needs a test for the two snippets, then LGTM

@daniel-sanche

daniel-sanche commented Feb 8, 2019

Copy link
Copy Markdown
MemberAuthor

The issue with testing these is that it requires an endpoints backed to be deployed for it to work as intended. If you think it's necessary, I could test the jwt creation function in isolation, but it feels like that would be more a test of the jwt/cyptography libraries I'm using rather than the sample itself

@kurtisvg

kurtisvg commented Feb 8, 2019

Copy link
Copy Markdown
Contributor

No, that seems like a reasonable explanation.

@daniel-sanche
daniel-sanche merged commit 7bfc2ff into GoogleCloudPlatform:masterFeb 8, 2019
@daniel-sanche
daniel-sanche deleted the endpoints-auth branch February 8, 2019 21:35
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kurtisvgkurtisvgkurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@daniel-sanche@kurtisvg@googlebot