Skip to content

Add samples for Data Catalog lookupEntry - #1416

Merged
kurtisvg merged 12 commits into
GoogleCloudPlatform:masterfrom
ricardolsmendes:task/add-lookup-entry-samples
May 14, 2019
Merged

Add samples for Data Catalog lookupEntry#1416
kurtisvg merged 12 commits into
GoogleCloudPlatform:masterfrom
ricardolsmendes:task/add-lookup-entry-samples

Conversation

@ghost

@ghostghost commented May 13, 2019

Copy link
Copy Markdown

Adding samples to Data Catalog lookup_entry, according to #1410

@ghost
ghost self-requested a review May 13, 2019 19:10
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 13, 2019
@lesv

lesv commented May 13, 2019

Copy link
Copy Markdown
Contributor

PTAL the new sample format in CONTRIBUTING.md @kurtisvg for additional info.

@ghost

ghost commented May 13, 2019•
edited by ghost
Loading

Copy link
Copy Markdown
Author

PTAL the new sample format in CONTRIBUTING.md @kurtisvg for additional info.

Thanks @lesv! I just noticed I missed the Gradle build file. Did I miss anything else?

@kurtisvg

kurtisvg commented May 13, 2019

Copy link
Copy Markdown
Contributor

It's highly suggested to use the updated sample format, which has guidelines here. This is to avoid having to update the samples again in the new future.

@lesv

lesv commented May 13, 2019

Copy link
Copy Markdown
Contributor

My quick glance was that I didn't see the comments on the parameters being passed, so I didn't scan the rest of the sample. https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/SAMPLE_FORMAT.md

And take a look here: https://github.com/GoogleCloudPlatform/java-docs-samples/tree/master/dlp/src/main/java/dlp/snippets

@ghost

ghost commented May 13, 2019

Copy link
Copy Markdown
Author

Just pushed a new version with several changes. I believe it's more consistent with the recommended standards now.

@kurtisvgkurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-teamkokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. labels May 14, 2019
kurtisvg
kurtisvg suggested changes May 14, 2019
View reviewed changes

@kurtisvgkurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL at CI tests as well.

Comment threaddatacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java
Comment threaddatacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java Outdated
Comment threaddatacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java Outdated
Comment threaddatacatalog/cloud-client/src/main/java/com/example/datacatalog/LookupEntryBigQueryDataset.java Outdated
Comment thread...talog/cloud-client/src/test/java/com/example/datacatalog/LookupEntryBigQueryDatasetTest.java
Ricardo Mendesand others added 2 commits May 14, 2019 13:21
Ricardo Mendes@kurtisvg
Update LookupEntryBigQueryDataset.java
95e7693
Co-Authored-By: Kurtis Van Gent <31518063+kurtisvg@users.noreply.github.com>
Ricardo Mendes
Update code to keep consistecyt with repo standards
aef7843
@kurtisvgkurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-teamkokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kurtisvgkurtisvg added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels May 14, 2019
kurtisvg
kurtisvg suggested changes May 14, 2019
View reviewed changes

@kurtisvgkurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits, otherwise LGTM when the tests pass.

Comment threaddatacatalog/cloud-client/src/main/java/com/example/datacatalog/QuickStart.java Outdated
Comment threaddatacatalog/cloud-client/pom.xml Outdated
@kurtisvgkurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kurtisvgkurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kurtisvgkurtisvg added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kurtisvgkurtisvg added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kokoro-teamkokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 14, 2019
@kurtisvg

kurtisvg commented May 14, 2019

Copy link
Copy Markdown
Contributor

fixes #1410

@kurtisvg
kurtisvg merged commit 0730123 into GoogleCloudPlatform:masterMay 14, 2019
@ghost
ghost deleted the task/add-lookup-entry-samples branch May 14, 2019 19:40
@charlieyu1996charlieyu1996 mentioned this pull request Nov 11, 2022
Merged
9 tasks
charlieyu1996 pushed a commit that referenced this pull request Nov 11, 2022
Ricardo Mendes@chingor13
samples: Add samples for Data Catalog lookupEntry (#1416)
23c7054
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lesv@kurtisvg@googlebot@kokoro-team