Skip to content

Automl GA - #1729

Merged
nnegrey merged 12 commits into
masterfrom
automl-ga
Nov 15, 2019
Merged

Automl GA#1729
nnegrey merged 12 commits into
masterfrom
automl-ga

Conversation

@nnegrey

@nnegreynnegrey commented Nov 12, 2019

Copy link
Copy Markdown
Contributor

Add samples for the AutoML GA of:

  • Natural Language (New samples)
    • Text Classification
    • Entity Extraction
    • Sentiment Analysis
  • Vision (New samples)
    • Image Classification
    • Object Detection
  • Translation (Lint updates)

@nnegrey
nnegrey requested a review from a teamNovember 12, 2019 21:31
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 12, 2019
kurtisvg
kurtisvg suggested changes Nov 12, 2019
View reviewed changes

@kurtisvgkurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future can we break these into smaller CLs? 44 is a little hard to review at once.

Comment threadautoml/cloud-client/src/main/java/com/example/automl/LanguageBatchPredict.java
Comment threadautoml/cloud-client/src/main/java/com/example/automl/LanguageEntityExtractionCreateModel.java
Comment threadautoml/cloud-client/src/main/java/com/example/automl/LanguageEntityExtractionPredict.java Outdated
Comment threadautoml/cloud-client/src/main/java/com/example/automl/LanguageSentimentAnalysisPredict.java
Comment thread...cloud-client/src/test/java/com/example/automl/LanguageEntityExtractionModelManagementIT.java
Comment thread...cloud-client/src/test/java/com/example/automl/LanguageEntityExtractionModelManagementIT.java
kurtisvg
kurtisvg approved these changes Nov 14, 2019
View reviewed changes

@kurtisvgkurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits, otherwise LGTM

Comment threadautoml/cloud-client/src/main/java/com/example/automl/VisionBatchPredict.java Outdated
Comment threadautoml/cloud-client/src/test/java/com/example/automl/GenericModelManagementIT.java Outdated
Comment thread...cloud-client/src/test/java/com/example/automl/LanguageEntityExtractionModelManagementIT.java
Comment threadautoml/cloud-client/src/test/java/com/example/automl/LanguageEntityExtractionPredictIT.java Outdated
Comment threadautoml/cloud-client/src/test/java/com/example/automl/LanguageEntityExtractionPredictIT.java
@nnegrey
nnegrey merged commit 81ff240 into masterNov 15, 2019
@nnegrey
nnegrey deleted the automl-ga branch November 15, 2019 21:52
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
@nnegrey@chingor13
samples: Automl GA (#1729)
cc93727
* Add Natural Language GA Samples
* Add Undeploy Model
* Add Vision Classification Samples
* Add Vision Object Detection Samples
* Lint
* Update samples based on feedback: remove unhelpful descriptions, add wrapper to env variables in tests
* Add comment to explain why the create model call doesn't wait for compeletion
* Update comment wording
* Update method comment, only check env var for tests before class, remove javadoc comments
@ShabirmeanShabirmean mentioned this pull request Nov 17, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
@nnegrey@Shabirmean
samples: Automl GA (#1729)
a55aac1
* Add Natural Language GA Samples
* Add Undeploy Model
* Add Vision Classification Samples
* Add Vision Object Detection Samples
* Lint
* Update samples based on feedback: remove unhelpful descriptions, add wrapper to env variables in tests
* Add comment to explain why the create model call doesn't wait for compeletion
* Update comment wording
* Update method comment, only check env var for tests before class, remove javadoc comments
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
@nnegrey@anguillanneuf
samples: Automl GA (#1729)
de1bebb
* Add Natural Language GA Samples
* Add Undeploy Model
* Add Vision Classification Samples
* Add Vision Object Detection Samples
* Lint
* Update samples based on feedback: remove unhelpful descriptions, add wrapper to env variables in tests
* Add comment to explain why the create model call doesn't wait for compeletion
* Update comment wording
* Update method comment, only check env var for tests before class, remove javadoc comments
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kurtisvgkurtisvgkurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvgkurtisvg

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nnegrey@kurtisvg@googlebot