Skip to content

feat: adding CreateCluster sample for Dataproc - #1734

Merged
bradmiro merged 15 commits into
masterfrom
dataproc-samples
Nov 15, 2019
Merged

feat: adding CreateCluster sample for Dataproc#1734
bradmiro merged 15 commits into
masterfrom
dataproc-samples

Conversation

@bradmiro

@bradmirobradmiro commented Nov 14, 2019

Copy link
Copy Markdown
Contributor

This PR adds a sample that creates a Dataproc cluster using the Java Client Library.

@bradmiro
bradmiro requested review from a team and lesvNovember 14, 2019 00:19
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 14, 2019
kurtisvg
kurtisvg suggested changes Nov 14, 2019
View reviewed changes
Comment threaddataproc/pom.xml Outdated
Comment threaddataproc/src/main/java/CreateCluster.java Outdated
Comment threaddataproc/src/main/java/CreateCluster.java Outdated
Comment threaddataproc/pom.xml
Comment threaddataproc/pom.xml Outdated
Comment threaddataproc/src/main/java/CreateCluster.java Outdated
Comment threaddataproc/src/main/java/CreateCluster.java Outdated
Comment threaddataproc/src/test/java/CreateClusterTest.java Outdated
Comment threaddataproc/src/test/java/CreateClusterTest.java Outdated
Comment threaddataproc/src/test/java/CreateClusterTest.java Outdated
@bradmiro

bradmiro commented Nov 15, 2019

Copy link
Copy Markdown
ContributorAuthor

Most of @kurtisvg's suggestions fixed with these commits. I left a comment on one suggestion.

kurtisvg
kurtisvg approved these changes Nov 15, 2019
View reviewed changes

@kurtisvgkurtisvg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the one comment

Comment threaddataproc/pom.xml Outdated
Comment threaddataproc/src/main/java/CreateCluster.java
@bradmiro
bradmiro merged commit d1ac030 into masterNov 15, 2019
@bradmiro
bradmiro deleted the dataproc-samples branch November 15, 2019 20:55
olivi-eh pushed a commit that referenced this pull request Nov 11, 2022
@bradmiro@chingor13
samples: feat: adding CreateCluster sample for Dataproc (#1734)
0baedc3
* refactored and added tags to infinite speech streaming sample (#1605)
* Changed 'main' region tag
* Removed extra lines around tags and changed client import to v1
* Create dataproc directory and add CreateCluster sample
* reverting changes to speech infinite streaming sample
* Added java versions to pom
* Several changes to file formatting as per request in the PR
* Added comments to exceptions in CreateCluster, expanded exceptions and femoved endpoint configuring in CreateClusterTest.java
* Fixed version for parent config
* Added clarity to futures requests by expanding variables
* Fixed linting errors
* Fixed import ordering
* Moved exceptions to function level in dataproc create cluster sample + test
@olivi-eholivi-eh mentioned this pull request Nov 11, 2022
Merged
9 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lesvlesvAwaiting requested review from lesv
1 more reviewer
@kurtisvgkurtisvgkurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvgkurtisvg

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bradmiro@kurtisvg@googlebot