Uh oh!
There was an error while loading. Please reload this page.
automl: break up and simplify the dataset tests - #1930
Merged
Conversation
averikitsch
approved these changes
Jan 3, 2020
| <!-- [START automl_java_dependencies] --> | ||
| <!-- Using libraries-bom to manage versions. | ||
| See https://github.com/GoogleCloudPlatform/cloud-opensource-java/wiki/The-Google-Cloud-Platform-Libraries-BOM --> | ||
| <dependencyManagement> |
Contributor
There was a problem hiding this comment.
Is the new version not in the BOM? If so do we know when it will be released?
ContributorAuthor
There was a problem hiding this comment.
No, not yet.
It is pushed to java-cloud-bom: https://github.com/googleapis/java-cloud-bom/blob/master/pom.xml#L207
Which is also in cloud-opensource-java: https://github.com/GoogleCloudPlatform/cloud-opensource-java/blob/ca1dede295e2db75fc7a8148fddadbbf102af80c/boms/cloud-oss-bom/pom.xml#L48
But not sure of their release process. But 3.3.0 did not contain it.
| String got = bout.toString(); | ||
| assertThat(got).contains("Dataset id:"); | ||
| datasetId = got.split("Dataset id: ")[1].split("\n")[0]; |
Contributor
There was a problem hiding this comment.
Is there a purpose for getting the datasetId?
ContributorAuthor
There was a problem hiding this comment.
To delete it in the teardown.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nnegrey
marked this pull request as ready for review
January 6, 2020 19:06
…ng running tests until fixed in following PRs
nnegrey
commented
Jan 7, 2020
ContributorAuthor
Note: Adding ignore to several long running tests that will be fixed in:
Skipped tests:
|
averikitsch
approved these changes
Jan 7, 2020
Shabirmean pushed a commit
that referenced
this pull request
Nov 17, 2022
* automl: break up and simplify dataset tests * remove bom from automl until bom is released with v1 of client library * Fix assert statement * Update license years and clean up comments * Remove score_threshold from Batch Predict * Fix typo in test * Switch tests to use centralized automl project, temporarily ignore long running tests until fixed in following PRs * Fix which project is used * Fix bucket path typo * lint: remove extra semi-colon
9 tasks
Shabirmean pushed a commit
that referenced
this pull request
Nov 18, 2022
* automl: break up and simplify dataset tests * remove bom from automl until bom is released with v1 of client library * Fix assert statement * Update license years and clean up comments * Remove score_threshold from Batch Predict * Fix typo in test * Switch tests to use centralized automl project, temporarily ignore long running tests until fixed in following PRs * Fix which project is used * Fix bucket path typo * lint: remove extra semi-colon
anguillanneuf pushed a commit
that referenced
this pull request
Dec 5, 2022
* automl: break up and simplify dataset tests * remove bom from automl until bom is released with v1 of client library * Fix assert statement * Update license years and clean up comments * Remove score_threshold from Batch Predict * Fix typo in test * Switch tests to use centralized automl project, temporarily ignore long running tests until fixed in following PRs * Fix which project is used * Fix bucket path typo * lint: remove extra semi-colon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.