Skip to content

feat: dataproc instantiate inline workflow sample - #2360

Merged
bradmiro merged 8 commits into
masterfrom
dataproc-samples
Mar 24, 2020
Merged

feat: dataproc instantiate inline workflow sample#2360
bradmiro merged 8 commits into
masterfrom
dataproc-samples

Conversation

@bradmiro

Copy link
Copy Markdown
Contributor

Adding a sample showing how to instantiate an inline workflow for dataproc.

@bradmiro
bradmiro requested a review from a teamMarch 9, 2020 21:38
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 9, 2020
@bradmirobradmiro assigned kurtisvg and unassigned nnegreyMar 9, 2020
@lesvlesv assigned lesv and unassigned kurtisvgMar 9, 2020
lesv
lesv approved these changes Mar 9, 2020

@lesvlesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This basically appears ok, but I question why it's a useful example/sample. What are you teaching users by using a preinstalled jar?

Comment threaddataproc/src/main/java/InstantiateInlineWorkflow.java
@lesv

lesv commented Mar 10, 2020

Copy link
Copy Markdown
Contributor

Do you need me to merge?

@bradmiro

Copy link
Copy Markdown
ContributorAuthor

I can merge! I'm finishing these up in a couple other languages and will merge when all are done, probably tomorrow :) thanks!

@bradmiro
bradmiro merged commit c3bccc3 into masterMar 24, 2020
@bradmiro
bradmiro deleted the dataproc-samples branch March 24, 2020 16:49
olivi-eh pushed a commit that referenced this pull request Nov 11, 2022
* Adding Dataproc InstantiateInlineWorkFlow samples
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@bradmiro@lesv@googlebot@nnegrey@kurtisvg