Uh oh!
There was an error while loading. Please reload this page.
Conversation
lesv
left a comment
There was a problem hiding this comment.
PTAL
I've sent you a list of books. The main one is Effective Java 3rd ed.
If your POM inherits from our shared-configuration:
<dependency>
<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.0.12</version>
<type>pom</type>
</dependency>
You should be able to domvn checkstyle:check.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
I had to disable surefires automatic testing via skipTests in pom.xml to deploy the code. (The tests rely on environment variables, which aren't provisioned until the tests finish on GCF - a catch-22.)
That seems to disable local tests too (e.g. when mvn clean verify is called), which is not what I wanted. I assume we can disable tests only on GCF deploys, but I don't know what the best way to do this is.
(Arguably, the GCF deployment process shouldn't be calling test goals.)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ace-n
commented
Mar 16, 2020
(Related question: should we document how to include files alongside your function like we do for other languages?) |
lesv
commented
Mar 16, 2020
re-disabling surefire, we should enable but set appropriate defaults so users can run. |
Uh oh!
There was an error while loading. Please reload this page.
lesv
left a comment
There was a problem hiding this comment.
Once you figure out surefire, LGTM
Uh oh!
There was an error while loading. Please reload this page.
I've tried to trigger profiles (for "only test locally" purposes) based on three things:
@lesv thoughts? May 2020 update: we decided to go with env-var-based profiles, specifically skipping tests when |
Uh oh!
There was an error while loading. Please reload this page.
* Add Slack sample + clean up imports * Address comments * Remove excess gcloudignore + actually disable tests * Simplify tests + run them on Kokoro. ALSO bugfix unused shellchecks. * Remove extra file * HACK: resolve surefire issue via file presence * HACK take 2: use a different filepath * HACK take 3: use env var not used by local Cloud Build * Remove gitignore now that config.json isnt used * DBG: print defined env vars * DBG take 2 * DBG take 3 * DBG take 4 * DBG take 5 * DBG take 6 * DBG take 7 * Fix tests...? * Revert dbg commits + fix tests
Forgot these in #2394 - cc @averikitsch@grant as FYI.
Do not merge until this has actually been tested with Slack.(@lesv I added you since Kurtis is OOO - LMK if I should ping someone else!)