Skip to content

fix: talent solution v4 samples tests - #2977

Merged
lesv merged 7 commits into
masterfrom
talent-sln-v4-bugs
May 28, 2020
Merged

fix: talent solution v4 samples tests#2977
lesv merged 7 commits into
masterfrom
talent-sln-v4-bugs

Conversation

@munkhuushmgl

Copy link
Copy Markdown
Contributor

Fixes#2970

Looks like job posting by default was expired and deleted in 30 days.
That's why this happens once in a month.

I found out that I can customize the expiration date in job posting, and created one job for testing that expires in 40 years from now.

@munkhuushmgl
munkhuushmgl requested a review from a teamMay 27, 2020 03:56
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 27, 2020

@lesvlesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, but I really think using protobuf.Timestamp is a very bad idea and should be discouraged.

Comment threadjobs/v4/src/main/java/com/example/jobs/JobSearchCreateJob.java Outdated
Comment threadjobs/v4/src/main/java/com/example/jobs/JobSearchCreateJob.java Outdated
@munkhuushmgl

Copy link
Copy Markdown
ContributorAuthor

@lesv Looks like I do not have a write permission to merge this

@lesv
lesv merged commit 86cea4d into masterMay 28, 2020
@lesv
lesv deleted the talent-sln-v4-bugs branch May 28, 2020 17:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HistogramSearchJobsTest: testHistogramSearch failed

4 participants

@munkhuushmgl@lesv@googlebot@stephaniewang526