Fixes the Endpoints getting-started sample. by wmwong · Pull Request #585 · GoogleCloudPlatform/java-docs-samples

wmwong · 2017-03-27T21:34:56Z

The Dockerfile and openapi.yaml cannot be in the appengine directory.
These have been moved out into their own directories.

Also, the jetty user needs access to the war file. The Dockerfile has
been updated accordingly.

The Dockerfile and openapi.yaml cannot be in the appengine directory. These have been moved out into their own directories. Also, the jetty user needs access to the war file. The Dockerfile has been updated accordingly.

codecov-io · 2017-03-27T21:58:02Z

Codecov Report

Merging #585 into master will not change coverage.
The diff coverage is n/a.

@@ Coverage Diff @@## master #585 +/- ##
=======================================
Coverage 51% 51% Complexity 245 245 =======================================
Files 87 87 Lines 2786 2786 Branches 185 185 =======================================
Hits 1421 1421 Misses 1315 1315 Partials 50 50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10fc75a...240ce3e. Read the comment docs.

lesv · 2017-03-27T23:37:08Z

@frankyn PTAL
@wmwong - A bit surprised by this, but Frank should know for sure.

frankyn · 2017-03-28T23:19:45Z

@lesv I agree with this change.

2 cents:
There are issues in the associated doc on cloudsite that need to be updated as well. Instructions expect files to be located in java-docs-samples/endpoints/getting-started/, but they're located in endpoints/getting-started/src/main/appengine/.

Action-item Paths need to be updated in the associated doc on cloudsite along with this PR.

lesv · 2017-03-29T00:42:02Z

@dpebot merge when green

dpebot · 2017-03-29T00:42:03Z

Okay! I'll merge when all statuses are green and all reviewers approve.

lesv · 2017-03-29T00:53:52Z

Docs have been updated, waiting on review from Frank and Lawrence.

frankyn · 2017-03-29T17:05:47Z

Hi @wmwong,

I missed a detail on my first pass.

I have a question, why did you place the openapi.yaml in src/main/openapi instead of in the root of this sample endpoints/getting-started? I'm not sure if there were complications, but if not we should move this down to the root of the sample. I can commit a change for this.

…dPlatform/java-docs-samples into fix-endpoints-getting-started

…orting to v0.121.4-beta (#585)

…1.3 (#585) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).

…2.0 (#585) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `25.1.0` -> `25.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/compatibility-slim/25.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.2.0/confidence-slim/25.1.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-notification).

…1.3 (#585) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.1.2` -> `26.1.3` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/compatibility-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.3/confidence-slim/26.1.2)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail).

* chore: fix batch test * fixed nit * 🦉 Updates from OwlBot * Update samples/snippets/src/test/java/com/example/translate/BatchTranslateTextTests.java Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Averi Kitsch <akitsch@google.com>

…8.0 (#585) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java) | `20.7.0` -> `20.8.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.8.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.8.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.8.0/compatibility-slim/20.7.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.8.0/confidence-slim/20.7.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dlp).

Fixes the Endpoints getting-started sample.
46b52f2
The Dockerfile and openapi.yaml cannot be in the appengine directory. These have been moved out into their own directories. Also, the jetty user needs access to the war file. The Dockerfile has been updated accordingly.

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 27, 2017

wmwong mentioned this pull request Mar 27, 2017
Endpoints AppEngine Flex sample doesn't deploy #583
Closed

lesv requested a review from frankyn March 27, 2017 23:36

Merge branch 'master' into fix-endpoints-getting-started
87484cb

frankyn approved these changes Mar 28, 2017
View reviewed changes

Merge branch 'master' into fix-endpoints-getting-started
d9a4e69

lesv added the automerge label Mar 29, 2017

lesv assigned dpebot Mar 29, 2017

dpebot added the automerge label Mar 29, 2017

lesv unassigned dpebot Mar 29, 2017

wmwong added 2 commits March 29, 2017 12:13

Move openapi.yaml to the root.
9b5cd96

Merge branch 'fix-endpoints-getting-started' of github.com:GoogleClou…
240ce3e
…dPlatform/java-docs-samples into fix-endpoints-getting-started

frankyn merged commit 52a9709 into masterMar 29, 2017

lesv deleted the fix-endpoints-getting-started branch April 6, 2017 00:53

minherz pushed a commit that referenced this pull request Nov 9, 2022
chore(deps): update dependency com.google.cloud:google-cloud-errorrep…
c46487c
…orting to v0.121.4-beta (#585)

minherz pushed a commit that referenced this pull request Nov 10, 2022
chore(deps): update dependency com.google.cloud:google-cloud-errorrep…
781093b
…orting to v0.121.4-beta (#585)

minherz pushed a commit that referenced this pull request Nov 10, 2022
chore(deps): update dependency com.google.cloud:google-cloud-errorrep…
d976d1c
…orting to v0.121.4-beta (#585)

Shabirmean mentioned this pull request Nov 10, 2022
samples: migrate code from googleapis/java-retail #7403
Merged
9 tasks

olivi-eh mentioned this pull request Nov 11, 2022
migrate code from googleapis/java-notification #7406
Closed
9 tasks

Shabirmean mentioned this pull request Nov 17, 2022
samples: migrate code from googleapis/java-translate #7443
Closed
9 tasks

Shabirmean mentioned this pull request Nov 18, 2022
samples: migrate code from googleapis/java-translate #7445
Merged
9 tasks

Navigation Menu

Uh oh!

Fixes the Endpoints getting-started sample. - #585

Fixes the Endpoints getting-started sample.#585
frankyn merged 5 commits into
masterfrom
fix-endpoints-getting-started

wmwong commented Mar 27, 2017•
edited by dpebot
Loading

Uh oh!

codecov-io commented Mar 27, 2017•
edited
Loading

Uh oh!

lesv commented Mar 27, 2017

Uh oh!

frankyn commented Mar 28, 2017

Uh oh!

lesv commented Mar 29, 2017

Uh oh!

dpebot commented Mar 29, 2017

Uh oh!

lesv commented Mar 29, 2017

Uh oh!

frankyn commented Mar 29, 2017•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

wmwong commented Mar 27, 2017• edited by dpebot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov-io commented Mar 27, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

lesv commented Mar 27, 2017

Uh oh!

frankyn commented Mar 28, 2017

Uh oh!

lesv commented Mar 29, 2017

Uh oh!

dpebot commented Mar 29, 2017

Uh oh!

lesv commented Mar 29, 2017

Uh oh!

frankyn commented Mar 29, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

wmwong commented Mar 27, 2017•
edited by dpebot
Loading

codecov-io commented Mar 27, 2017•
edited
Loading

frankyn commented Mar 29, 2017•
edited
Loading