Skip to content

docs(compute-samples): added parallel testing support - #7071

Merged
Sita04 merged 12 commits into
mainfrom
compute-samples-parallel-testing
May 13, 2022
Merged

docs(compute-samples): added parallel testing support#7071
Sita04 merged 12 commits into
mainfrom
compute-samples-parallel-testing

Conversation

@Sita04

@Sita04Sita04 commented Apr 27, 2022

Copy link
Copy Markdown
Contributor

Added parallel testing support for samples with mvn surefire and JUnit jupiter.

@Sita04
Sita04 requested review from a team and yoshi-approver as code ownersApril 27, 2022 15:06
@product-auto-labelproduct-auto-labelBot added the samples Issues that are directly related to samples. label Apr 27, 2022
@Sita04
Sita04 requested a review from kurtisvgApril 27, 2022 15:09
This was referenced Apr 27, 2022
Merged
Closed
Closed
@Sita04Sita04 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
@kokoro-teamkokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 27, 2022
Shabirmean
Shabirmean reviewed Apr 29, 2022
View reviewed changes

@ShabirmeanShabirmean left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general LGTM! Left some nit comments.

Tagging @lesv since I am still a a shadow reviewer. I see @kurtisvg is already in the reviewer list. So removing les

Comment threadcompute/cloud-client/src/main/java/compute/CreateEncryptedInstance.java Outdated
Comment threadcompute/cloud-client/src/main/java/compute/CreateFirewallRule.java Outdated
Comment threadcompute/cloud-client/src/main/java/compute/CreateInstance.java Outdated
Comment threadcompute/cloud-client/src/test/java/compute/FirewallIT.java Outdated
Comment threadcompute/cloud-client/src/test/java/compute/FirewallIT.java Outdated
Comment threadcompute/cloud-client/src/test/java/compute/InstancesAdvancedIT.java Outdated
@kurtisvg
kurtisvgforce-pushed the compute-samples-parallel-testing branch from 472c63d to bdb19f9CompareApril 29, 2022 21:10
@Sita04
Sita04 requested a review from ShabirmeanMay 11, 2022 11:30
@Sita04
Sita04 merged commit e9dec4f into mainMay 13, 2022
@Sita04
Sita04 deleted the compute-samples-parallel-testing branch May 13, 2022 06:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshi-approveryoshi-approverAwaiting requested review from yoshi-approveryoshi-approver is a code owner
@ShabirmeanShabirmeanAwaiting requested review from Shabirmean
1 more reviewer
@kurtisvgkurtisvgkurtisvg approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ShabirmeanShabirmean

Labels

samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Sita04@Shabirmean@kurtisvg@kokoro-team