Pusher on App Engine sample by jabubake · Pull Request #798 · GoogleCloudPlatform/java-docs-samples

jabubake · 2017-08-09T04:57:50Z

No description provided.

jabubake · 2017-08-09T05:05:53Z

Closing this pull request, it looks like the code will need to live @ community repository for it to be embedded in the article.

jabubake · 2017-08-09T16:20:09Z

@lesv : reopening, it feels better to have this code reviewed and exist in our repository. I might clone it as needed for the community article.

…form/java-docs-samples into appengine-pusher

lesv · 2017-08-09T17:16:33Z

+
+#### Setup Pusher
+
+- Create a [Pusher] application and note down the `app_id`, `app_key`, `app_secret` and the cluster.


Is [Pusher] enough?

Yes, that seems to work.

lesv · 2017-08-09T17:17:02Z

+ <version>1.0-SNAPSHOT</version>
+ <groupId>com.example.appengine</groupId>
+ <artifactId>appengine-pusher-chat</artifactId>
+


parent pom?

I'd missed that, just added.

lesv · 2017-08-09T17:17:19Z

+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
+ <version>20.0</version>


for support with 1.7, 20.0 is the last version we can use.

lesv · 2017-08-09T17:17:41Z

+ <dependency>
+ <groupId>javax.servlet</groupId>
+ <artifactId>servlet-api</artifactId>
+ <version>2.5</version>


3.1 and target GAE Std J8?

As discussed offline

lesv · 2017-08-09T17:17:57Z

@@ -0,0 +1,49 @@
+# Pusher sample for Google App Engine


Shouldn't this go in J8

As discussed, I will leave it here for now, but will submit a separate PR for J8

lesv · 2017-08-09T17:18:16Z

+ <version>3.3</version>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <configuration>
+ <source>1.7</source>


lesv · 2017-08-09T17:18:51Z

+ <artifactId>appengine-pusher-chat</artifactId>
+
+ <properties>
+ <maven.compiler.source>1.8</maven.compiler.source>


doesn't match below -- nor is below actually needed.

lesv · 2017-08-09T17:20:59Z

+
+- Create a [Pusher] application and note down the `app_id`, `app_key`, `app_secret` and the cluster.
+- Update [appengine-web.xml](src/main/webapp/WEB-INF/appengine-web.xml) with these credentials.
+- Update Line 71 in [chat.jsp](src/main/webapp/WEB-INF/view/chat.jsp) with the `app_id` and cluster information.


I wonder if we could do a jsp to grab it from appengine-web.xml?

I wanted to keep the client side initialization simple and decoupled from the server-side to keep it easier to understand. It would be possible to do it via ServletContextListener and then access the data in both places. I can see it being a problem for testing though, let me know what you think.

I was thinking just access a public constant from the jsp, but I can imagine more. I'm also totally ok to skip this.

lesv · 2017-08-09T17:22:22Z

+ xmlns:web="http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd"
+ xsi:schemaLocation="http://java.sun.com/xml/ns/javaee http://java.sun.com/xml/ns/javaee/web-app_2_5.xsd"
+ version="2.5">
+ <servlet>


Use 3.1 annotations in the source files

jabubake · 2017-08-09T21:08:28Z

@lesv PTAL when you get a chance

…form/java-docs-samples into appengine-pusher

jabubake · 2017-08-09T21:36:21Z

+
+ // Connect to Pusher with auth endpoint on your server for private/presence channels
+ // (default auth endpoint : /pusher/auth)
+ var pusher = new Pusher('<%= PusherService.APP_KEY %>', {


Switched to static vars, @lesv

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1.0 (#798) [![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `25.0.0` -> `25.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.1.0/compatibility-slim/25.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/25.1.0/confidence-slim/25.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-document-ai).

jabubake added 7 commits August 4, 2017 14:08

adding Pusher sample
52f59ca

adding doc tags
8e479d8

adding doc tags
3112453

doc updates
15466da

cleanup
75395ea

updating
609231b

updating README
bdff334

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 9, 2017

Merge branch 'master' into appengine-pusher
5aa731d

jabubake requested a review from lesv August 9, 2017 04:58

jabubake closed this Aug 9, 2017

jabubake reopened this Aug 9, 2017

jabubake added 2 commits August 9, 2017 09:27

updating README
8ae81bb

Merge branch 'appengine-pusher' ofhttps://github.com/GoogleCloudPlat…
707888b
…form/java-docs-samples into appengine-pusher

lesv suggested changes Aug 9, 2017
View reviewed changes

jabubake added 2 commits August 9, 2017 14:01

removing 1.8 references
5b956b8

adding parent dependency
88f00f4

jabubake added 3 commits August 9, 2017 14:08

Merge branch 'master' into appengine-pusher
3414941

using static vars in JSP for pusher app id, cluster info
a3967b5

Merge branch 'appengine-pusher' ofhttps://github.com/GoogleCloudPlat…
bcf423f
…form/java-docs-samples into appengine-pusher

jabubake commented Aug 9, 2017
View reviewed changes

lesv approved these changes Aug 9, 2017
View reviewed changes

jabubake merged commit c9de8e5 into masterAug 9, 2017

jabubake deleted the appengine-pusher branch August 9, 2017 21:40

Sita04 mentioned this pull request Nov 11, 2022
migrate code from googleapis/java-recaptchaenterprise #7417
Merged
9 tasks

Shabirmean mentioned this pull request Nov 15, 2022
samples: migrate code from googleapis/java-document-ai #7427
Merged
9 tasks


		#### Setup Pusher

		- Create a [Pusher] application and note down the `app_id`, `app_key`, `app_secret` and the cluster.

Uh oh!

Conversation

jabubake commented Aug 9, 2017

Uh oh!

jabubake commented Aug 9, 2017

Uh oh!

jabubake commented Aug 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jabubake commented Aug 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants