Skip to content

Speech samples - #843

Closed
jabubake wants to merge 5 commits into
masterfrom
speech-samples
Closed

Speech samples#843
jabubake wants to merge 5 commits into
masterfrom
speech-samples

Conversation

@jabubake

@jabubakejabubake commented Sep 7, 2017

Copy link
Copy Markdown
Contributor

@jabubakejabubake added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 7, 2017
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2017
@jabubake

jabubake commented Sep 7, 2017

Copy link
Copy Markdown
ContributorAuthor

@dizcology@lesv Please hold off on review till I resolve the conflicts with master.

jabubake
jabubake commented Sep 7, 2017
View reviewed changes
Comment threadspeech/cloud-client/src/main/java/com/example/speech/QuickstartSample.java
import com.google.cloud.speech.v1.SpeechClient;
import com.google.cloud.speech.v1.SpeechRecognitionAlternative;
import com.google.cloud.speech.v1.SpeechRecognitionResult;
import com.google.cloud.speech.v1_1beta1.SpeechClient;

@jabubakejabubakeSep 7, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note : this may change

@lesvlesvSep 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope so.

lesv
lesv reviewed Sep 7, 2017
View reviewed changes
Comment threadspeech/cloud-client/src/main/java/com/example/speech/QuickstartSample.java
public static void main(String... args) throws Exception {
// Instantiates a client
SpeechClient speech = SpeechClient.create();
try (SpeechClient speechClient = SpeechClient.create()) {

@lesvlesvSep 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we use speech everywhere else, why not keep it consistent. (don't really care which one you choose, but speech is shorter.

lesv
lesv reviewed Sep 7, 2017
View reviewed changes
Comment threadspeech/cloud-client/src/main/java/com/example/speech/Recognize.java
}

List<SpeechRecognitionResult> results = response.get().getResultsList();
List<SpeechRecognitionResult> results = response.get().getResultsList();

@lesvlesvSep 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought the new standard for these things was just to show the top one?

lesv
lesv reviewed Sep 7, 2017
View reviewed changes
Comment threadspeech/cloud-client/src/test/java/com/example/speech/RecognizeIT.java
public void testAutomaticPunctuationFile() throws Exception {
Recognize.transcribeFileWithAutomaticPunctuation(audioFileName);
String got = bout.toString();
assertThat(got).contains("How");

@lesvlesvSep 7, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet this turns out to be too brittle, but LGTM for now

lesv
lesv approved these changes Sep 7, 2017
View reviewed changes

@lesvlesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit - I'm happy

@kurtisvg
kurtisvgforce-pushed the master branch 2 times, most recently from 6a140af to 6fc6424CompareJanuary 9, 2018 17:34
@kurtisvg
kurtisvg deleted the speech-samples branch February 14, 2018 20:30
minherz pushed a commit that referenced this pull request Nov 9, 2022
@renovate-bot@gcf-owl-bot
chore(deps): update dependency com.google.cloud:google-cloud-errorrep…
49ae294
…orting to v0.122.22-beta (#843)
* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.122.22-beta
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot@gcf-owl-bot@minherz
chore(deps): update dependency com.google.cloud:google-cloud-errorrep…
132a90d
…orting to v0.122.22-beta (#843)
* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.122.22-beta
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
minherz pushed a commit that referenced this pull request Nov 10, 2022
@renovate-bot@gcf-owl-bot@minherz
chore(deps): update dependency com.google.cloud:google-cloud-errorrep…
4125232
…orting to v0.122.22-beta (#843)
* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.122.22-beta
* 🦉 Updates from OwlBot post-processor
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
olivi-eh pushed a commit that referenced this pull request Nov 11, 2022
@renovate-bot
build(deps): update dependency org.sonatype.plugins:nexus-staging-mav…
6868ea9
…en-plugin to v1.6.13 (#843)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [org.sonatype.plugins:nexus-staging-maven-plugin](http://www.sonatype.com/) ([source](https://togithub.com/sonatype/nexus-maven-plugins)) | `1.6.11` -> `1.6.13` | [![age](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.13/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.13/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.13/compatibility-slim/1.6.11)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/org.sonatype.plugins:nexus-staging-maven-plugin/1.6.13/confidence-slim/1.6.11)](https://docs.renovatebot.com/merge-confidence/) |
---
### Release Notes
<details>
<summary>sonatype/nexus-maven-plugins</summary>
### [`v1.6.13`](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.12...release-1.6.13)
[Compare Source](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.12...release-1.6.13)
### [`v1.6.12`](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.11...release-1.6.12)
[Compare Source](https://togithub.com/sonatype/nexus-maven-plugins/compare/release-1.6.11...release-1.6.12)
</details>
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dataproc).
@olivi-eholivi-eh mentioned this pull request Nov 11, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:libraries-bom to v24.…
7e4ba5e
…3.0 (#843)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `24.2.0` -> `24.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/compatibility-slim/24.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/confidence-slim/24.2.0)](https://docs.renovatebot.com/merge-confidence/) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
@ShabirmeanShabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
@renovate-bot@Shabirmean
chore(deps): update dependency com.google.cloud:libraries-bom to v24.…
a492604
…3.0 (#843)
[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
This PR contains the following updates:
| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/GoogleCloudPlatform/cloud-opensource-java)) | `24.2.0` -> `24.3.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/compatibility-slim/24.2.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/24.3.0/confidence-slim/24.2.0)](https://docs.renovatebot.com/merge-confidence/) |
---
### Configuration
📅 **Schedule**: At any time (no schedule defined).
🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.
♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.
🔕 **Ignore**: Close this PR and you won't be reminded about this update again.
---
- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.
---
This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-dialogflow).
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dizcologydizcologyAwaiting requested review from dizcology
1 more reviewer
@lesvlesvlesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.do not mergeIndicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jabubake@lesv@googlebot