Skip to content

Update Cleanup DAG - #10771

Merged
rafalbiegacz merged 2 commits into
GoogleCloudPlatform:mainfrom
apilaskowski:correct_cleanup_dag
Oct 18, 2023
Merged

Update Cleanup DAG#10771
rafalbiegacz merged 2 commits into
GoogleCloudPlatform:mainfrom
apilaskowski:correct_cleanup_dag

Conversation

@apilaskowski

@apilaskowskiapilaskowski commented Oct 17, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolving issue #10772

@apilaskowski
apilaskowski requested review from a team as code ownersOctober 17, 2023 14:32
@product-auto-labelproduct-auto-labelBot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Oct 17, 2023
@apilaskowski

apilaskowski commented Oct 17, 2023

Copy link
Copy Markdown
ContributorAuthor

#10772

@apilaskowski
Update airflow_db_cleanup.py
12ce687
Missing empty line at the end.
@apilaskowski

apilaskowski commented Oct 17, 2023

Copy link
Copy Markdown
ContributorAuthor

I tested this change with Cloud Composer environment having Airflow 2.6.3 and everything passed correctly.

@leahecoleleahecole assigned leahecole and unassigned graysideOct 17, 2023
@apilaskowskiapilaskowski mentioned this pull request Oct 17, 2023
Merged
@apilaskowski

apilaskowski commented Oct 18, 2023

Copy link
Copy Markdown
ContributorAuthor

@leahecole is there something that I should do to unblock this? So it can be released?

@leahecole

leahecole commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

Hi - I was waiting to also be able to test on 2.6.3 but I'm not seeing it in the console yet. If you've tested it though, I supposed LGTM

@leahecole

leahecole commented Oct 18, 2023

Copy link
Copy Markdown
Collaborator

@apilaskowski you'll need one more reviewer - @rafalbiegacz has permissions

@apilaskowski

apilaskowski commented Oct 18, 2023•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

2.6.3 is not released yet.
I was able to test it in Composer, as I have access to development environments.

@rafalbiegacz
rafalbiegacz self-requested a review October 18, 2023 14:58
@apilaskowski

apilaskowski commented Oct 18, 2023

Copy link
Copy Markdown
ContributorAuthor

I also tested on 2.5.3, which should work with old logic.

@apilaskowski

apilaskowski commented Oct 18, 2023

Copy link
Copy Markdown
ContributorAuthor

@leahecole as you can see @rafalbiegacz tried, but it didn't work, so he is not an owner here. Whom should I ask for that?

@rafalbiegacz
rafalbiegacz merged commit ef6bca5 into GoogleCloudPlatform:mainOct 18, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecoleleahecoleleahecole approved these changes
@rafalbiegaczrafalbiegaczrafalbiegacz approved these changes

Assignees

@leahecoleleahecole

Labels

api: workflowsIssues related to the Workflows API.samplesIssues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@apilaskowski@leahecole@rafalbiegacz@grayside