Uh oh!
There was an error while loading. Please reload this page.
fix: sqlalchemy dependencies - #12760
Conversation
jackwotherspoon
commented
Nov 11, 2024
@wiktorn wouldn't MySQL and SQL Server folders also benefit from this change? MySQL: https://github.com/GoogleCloudPlatform/python-docs-samples/tree/main/cloud-sql/mysql/sqlalchemy |
wiktorn
commented
Nov 11, 2024
@jackwotherspoon Actually, both MySQL and SQL Server pinned python:3.11 (though different flavors). I aligned Dockerfiles and requirements.txt across these three. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jackwotherspoon
commented
Jan 23, 2025
jackwotherspoon
commented
Jan 23, 2025
I have fixed the previous errors about the missing env vars so 🤞 builds should all pass after rebasing the PR |
SQLAlchemy v2.0.24 fails with Python 3.13 with error:
```
AssertionError: Class <class 'sqlalchemy.sql.elements.SQLCoreOperations'> directly inherits TypingOnly but has additional attributes {'__static_attributes__'}.
```
[see bug GoogleCloudPlatform#11334](sqlalchemy/sqlalchemy#11334)
Bumping version of SQLAlchemy and fixing Python to version 3.13 to avoid
such problems in the future.6306134 to
6764846Comparewiktorn
commented
Jan 23, 2025
Thanks @jackwotherspoon I just rebased, hopefully this will solve the issue! |
jackwotherspoon
commented
Jan 23, 2025
Looks like all tests passed, just lint job failed for unable to get service account (flaky?), re-running tests to see if it was a a one off |
jackwotherspoon
left a comment
There was a problem hiding this comment.
LGTM ✅
Thanks @wiktorn looks like we are all green 👍
Description
SQLAlchemy v2.0.24 fails with Python 3.13 with error:
see bug #11334
Bumping version of SQLAlchemy and fixing Python to version 3.13 to avoid such problems in the future.
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)