Skip to content

Iot commands beta - #1746

Merged
gguuss merged 18 commits into
masterfrom
iot-commands-beta
Oct 17, 2018
Merged

Iot commands beta#1746
gguuss merged 18 commits into
masterfrom
iot-commands-beta

Conversation

@gguuss

@gguussgguuss commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 10, 2018
@googlebot

googlebot commented Oct 12, 2018

Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Oct 12, 2018
@gguuss

gguuss commented Oct 12, 2018

Copy link
Copy Markdown
ContributorAuthor

I signed it!

@tswast
tswast self-requested a review October 12, 2018 22:06
tswast
tswast reviewed Oct 12, 2018
View reviewed changes
Comment threadiot/api-client/beta-features/commands/README.md Outdated
Comment threadiot/api-client/beta-features/commands/receive/receive.py
Comment threadiot/api-client/beta-features/commands/receive/receive.py Outdated
ES256 private key.
algorithm: The encryption algorithm to use. Either 'RS256' or 'ES256'
Returns:
An MQTT generated from the given project_id and private key, which

@tswasttswastOct 12, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the type? bytes? str?

@gguussgguussOct 12, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

str AFAICT (utf-8)

Comment threadiot/api-client/beta-features/commands/receive/receive.py Outdated
Comment threadiot/api-client/beta-features/commands/receive/receive.py
Comment threadiot/api-client/beta-features/commands/receive/receive_test.py
Comment threadiot/api-client/beta-features/commands/receive/receive_test.py Outdated
Comment threadiot/api-client/beta-features/commands/receive/receive_test.py Outdated
Comment threadiot/api-client/beta-features/commands/receive/resources/rsa_private.pem
Comment threadiot/api-client/beta-features/commands/send/send_test.py Outdated
@gguuss
gguuss merged commit 820c29a into masterOct 17, 2018
@gguuss
gguuss deleted the iot-commands-beta branch October 17, 2018 17:29
@chalmerlowechalmerlowe mentioned this pull request Apr 7, 2026
Merged
9 tasks
chalmerlowe pushed a commit that referenced this pull request Apr 7, 2026
@chandra-siri
fix: don't flush at every append, results in bad perf (#1746)
543ec25
fix: don't flush at every append, results in bad perf
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

No one assigned

Labels

cla: noThis human has *not* signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gguuss@googlebot@tswast