Skip to content

Add a list of allowed_client_ids to EchoApi.get_user_email. - #1992

Merged
tswast merged 2 commits into
GoogleCloudPlatform:masterfrom
tomboc:master
Apr 11, 2019
Merged

Add a list of allowed_client_ids to EchoApi.get_user_email.#1992
tswast merged 2 commits into
GoogleCloudPlatform:masterfrom
tomboc:master

Conversation

@tomboc

Copy link
Copy Markdown
Contributor

The use of an OAuth token issued by accounts.google.com triggers
a special path in Endpoints Framework, which validates if the
client id ('azp' claim of JWT token) is included in allowed_client_ids
list supplied to @endpoints.method decorator.

Without the change, sample client described at [1] receives 401
Unauthorized errors when attempting to access the API.

[1] https://cloud.google.com/endpoints/docs/frameworks/python/javascript-client

The use of an OAuth token issued by accounts.google.com triggers
a special path in Endpoints Framework, which validates if the
client id ('azp' claim of JWT token) is included in allowed_client_ids
list supplied to @endpoints.method decorator.
Without the change, sample client described at [1] receives 401
Unauthorized errors when attempting to access the API.
[1] https://cloud.google.com/endpoints/docs/frameworks/python/javascript-client
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019

@daniel-sanchedaniel-sanche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast
tswast merged commit 35e8cab into GoogleCloudPlatform:masterApr 11, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tomboc@daniel-sanche@tswast@googlebot