Skip to content

Fix urllib2#2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
engelke merged 3 commits into from
Mar 20, 2019
Merged

Fix urllib2 #2059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b517ec7
fix urllib2 import
dizcology Mar 19, 2019
810b4c6
use six
dizcology Mar 19, 2019
9e1e39c
Merge branch 'master' into fix-urllib2
engelke Mar 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions video/cloud-client/analyze/beta_snippets_test.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,8 +14,8 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from six.moves.urllib.request import urlopen
import time
import urllib2
import uuid

import beta_snippets
Expand All@@ -29,7 +29,7 @@

@pytest.fixture(scope='session')
def video_path(tmpdir_factory):
file = urllib2.urlopen(
file = urlopen(
'http://storage.googleapis.com/cloud-samples-data/video/cat.mp4')
path = tmpdir_factory.mktemp('video').join('file.mp4')
with open(str(path), 'wb') as f:
Expand Down