Skip to content

IAM: added snippet for remove member - #2165

Merged
gguuss merged 6 commits into
GoogleCloudPlatform:masterfrom
DSdatsme:master
Aug 14, 2019
Merged

IAM: added snippet for remove member#2165
gguuss merged 6 commits into
GoogleCloudPlatform:masterfrom
DSdatsme:master

Conversation

@DSdatsme

Copy link
Copy Markdown
Contributor

Example code for removing a member in IAM policy.

@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label May 18, 2019
Comment threadiam/api-client/access.py

@gguussgguuss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let me know if you want me to merge or if you want to change the member in your test first.

Comment threadiam/api-client/access.py
@googlebot

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 14, 2019
@gguuss

Copy link
Copy Markdown
Contributor

I went ahead and pushed a few fixes for the tests to your fork.

@gguussgguuss added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 14, 2019
@googlebot

Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

Comment threadiam/api-client/access_test.py Outdated
policy = access.set_policy(project, policy)
policy = access.modify_policy_remove_member(policy, gcp_role, member)
out, _ = capsys.readouterr()
assert 'etag' in out

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm seeing this test failing in Python 2.

@gguuss
gguuss merged commit 9226981 into GoogleCloudPlatform:masterAug 14, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@DSdatsme@googlebot@gguuss