Uh oh!
There was an error while loading. Please reload this page.
Container Analysis samples - #2232
Conversation
017d257 to
95ba536Compareleahecole
commented
Jul 2, 2019
Disclaimer: I have NO container_analysis experience, but have used this repo before :) Here's how running this went: -Pretty please add a README so users know how you want them to run your code (that they need to install the requirements, let them know what needs to be enabled in their GCP Project, etc., any environment vars). Given that I've never used container analysis, I failed a bunch before I was able to successfully run stuff
|
daniel-sanche
commented
Jul 3, 2019
@leahecole I added a README, let me know if that looks better. Your pubsub issues may have been because the team recently switched from the beta topic to the GA one, so I updated the sample to use the new topic. Let me know what you think |
leahecole
left a comment
There was a problem hiding this comment.
pubsub test is also still giving me an error, and I wonder if it has to do with the incorrectly resolved dependency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| 1. **Set Environment Variables** | ||
| ``` | ||
| $ export GOOGLE_CLOUD_PROJECT="YOUR_PROJECT_ID" |
There was a problem hiding this comment.
GOOGLE_CLOUD_PROJECT -> GCLOUD_PROJECT
There was a problem hiding this comment.
Should users also set their application credentials here?
There was a problem hiding this comment.
Is that required? I don't have it set in my terminal and it's working, I assume because I authenticated locally with "gcloud login"
I'm not really sure how much detail is required for set up here, so I copied this readme from a different project
ea1e1d9 to
e8f79f8Comparedaniel-sanche
commented
Jul 4, 2019
Note that the tests aren't actually running, since this PR is based on a fork. I forgot that quirk of this repo Maybe after we resolve these comments I can close this and open another one as an internal branch? Let me know what you think |
leahecole
commented
Jul 8, 2019
Ooo I forgot that's a quirk of this repo also. @dansanche I think that after resolution, opening another one and linking it here in the comments is a fabulous idea. |
daniel-sanche
commented
Jul 8, 2019
@leahecole I believe I resolved the issues you mentioned, except setting application credentials. Let me know if you think that should be added |
leahecole
commented
Jul 8, 2019
Sorry, didn't process that properly. I think adding the application creds is a good idea because right now it throws a warning if you don't |
daniel-sanche
commented
Jul 8, 2019
sounds good, I'll add it to the new PR |
added Python samples for the Container Analysis GA