Uh oh!
There was an error while loading. Please reload this page.
Revert "fixing translate-with-glossary bug (#2323)" - #2326
Conversation
This reverts commit 1cf4d1f.
nnegrey
commented
Aug 9, 2019
It looks like tests un-related to those reverted changes are failing |
My PR's changes didn't cause any tests to fail; the tests were failing before I changed anything. I assumed that a Python2/Python3 distinction was causing them to fail for me locally, so I didn't mention it to anyone (which in retrospect I shouldn't have done). I'm also guessing that the product team changed something that changed the behavior of the API but Travis didn't catch it because it only builds for a PR, and this PR is the first time that anyone has changed the samples since their initial commit. |
nnegrey
commented
Aug 13, 2019
Going to close this as a separate PR has resolved these failing tests. |
This reverts commit 1cf4d1f.
This reverts this merged PR:
#2323
I got a notification the tests failed after this was merged:
The PR was green and therefore appeared safe to merge.
@nnegrey Any chance you could take a closer look w/ @ecrowdus?
In the meantime, this will revert the failing change, although it looks like a second translation test failed too 😕 ~ Use this PR if useful