Skip to content

removed 'speech_transcribe_infinite_streaming_init' region tag - #2456

Merged
bradmiro merged 5 commits into
bradmiro-stagefrom
master
Oct 8, 2019
Merged

removed 'speech_transcribe_infinite_streaming_init' region tag#2456
bradmiro merged 5 commits into
bradmiro-stagefrom
master

Conversation

@bradmiro

@bradmirobradmiro commented Oct 8, 2019

Copy link
Copy Markdown
Collaborator

Deleted region tag as it didn't make sense in the context of the other samples

gguussand others added 5 commits October 7, 2019 18:45
@gguuss@crwilcox
Adds updates for samples profiler ... vision (#2439)
78c213a
@grayside
cloud-sql: add Cloud Run support to sqlalchemy sample (#2449)
48e53b2
@gguuss@crwilcox
Adds split updates for Firebase ... opencensus (#2438)
7073d87
@gguuss@crwilcox
App engine upversion (#2437)
2b2cef9
* App engine upversion
* Python 2 compatible pytest
David Cavazos
Dataflow client library (#2450)
cbb910e
* Updated requirements
* Update service naming convention
* Prefer client libraries over shell commands
* Update README format
@googlebot

googlebot commented Oct 8, 2019

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebotgooglebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 8, 2019
@bradmiro
bradmiro merged commit be45ca8 into bradmiro-stageOct 8, 2019
@alixhami

alixhami commented Oct 8, 2019

Copy link
Copy Markdown
Contributor

This PR is pretty confusing. It looks like a lot more happened than just a region tag removal. Are you sure this didn't undo a bunch of other unrelated commits?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alixhamialixhamiAwaiting requested review from alixhami

Assignees

No one assigned

Labels

cla: noThis human has *not* signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bradmiro@googlebot@alixhami@gguuss@grayside