Uh oh!
There was an error while loading. Please reload this page.
automl: video beta move model samples from branch to master - #2754
Merged
Conversation
nnegrey
marked this pull request as ready for review
January 29, 2020 17:03
leahecole
requested changes
Jan 29, 2020
leahecole
left a comment
Collaborator
There was a problem hiding this comment.
The code itself looks good, but I'd like to propose either
- moving them into a subdirectory in beta called
video
OR - prefixing the filenames with
video_, like we do for language and vision in thecloud-clientfolder
Or, if y'all ML APIs folks have something you prefer in general that isn't one of those two things but still helps differentiate, I'm game for that too
Unless this isn't strictly video specific, in which case, they're great.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nnegrey
commented
Jan 29, 2020
ContributorAuthor
So while these samples are for the video beta, the samples can be used with any automl product. The samples that are only for video can be found on this PR and those have the |
nnegrey
commented
Jan 29, 2020
ContributorAuthor
But I did miss some |
leahecole
approved these changes
Jan 31, 2020
busunkim96 pushed a commit
to busunkim96/python-automl
that referenced
this pull request
Aug 7, 2020
…oogleCloudPlatform/python-docs-samples#2754) * automl: video beta move model samples from branch to master * Fix region tag Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit
to googleapis/python-automl
that referenced
this pull request
Aug 13, 2020
…oogleCloudPlatform/python-docs-samples#2754) * automl: video beta move model samples from branch to master * Fix region tag Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
arbrown pushed a commit
that referenced
this pull request
Nov 17, 2022
8 tasks
dandhlee pushed a commit
that referenced
this pull request
Nov 17, 2022
parthea pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Oct 21, 2023
…oogleCloudPlatform/python-docs-samples#2754) * automl: video beta move model samples from branch to master * Fix region tag Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.