Uh oh!
There was an error while loading. Please reload this page.
video: fix flaky beta tests - #3235
Merged
Merged
Conversation
nnegrey
commented
Mar 31, 2020
ContributorAuthor
Different test is failing, which has been untouched so I need to go figure out why it now has an invalid argument. Possibly a change in the beta? Investigating. |
nnegrey
commented
Mar 31, 2020
ContributorAuthor
Well turns out we don't even have tests for local files across the board. :O |
nnegrey
commented
Mar 31, 2020
ContributorAuthor
I think the cat video is corrupted. As each time I use that video, it fails. But I tried another and it works... |
telpirion
approved these changes
Apr 1, 2020
telpirion
left a comment
Contributor
There was a problem hiding this comment.
One super small nit, otherwise LGTM.
Uh oh!
There was an error while loading. Please reload this page.
tmatsuo
commented
Apr 7, 2020
Contributor
Thanks @nnegrey for the fix. I'll merge once the tests pass |
busunkim96 pushed a commit
to busunkim96/python-videointelligence
that referenced
this pull request
May 20, 2020
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
danoscarmike pushed a commit
to googleapis/python-videointelligence
that referenced
this pull request
Sep 30, 2020
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
dizcology pushed a commit
that referenced
this pull request
Sep 11, 2023
9 tasks
leahecole pushed a commit
that referenced
this pull request
Sep 15, 2023
parthea pushed a commit
to googleapis/google-cloud-python
that referenced
this pull request
Sep 22, 2023
…-samples#3235) * video: fix flaky beta tests * fix failing test with new video file * add local file tests * update test Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #3224
Fix: #3223
Fix: #3220