Skip to content

dialogflow: remove unused samples + tests - #3249

Merged
tmatsuo merged 19 commits into
GoogleCloudPlatform:masterfrom
Strykrol:snippetcleanup
Apr 23, 2020
Merged

dialogflow: remove unused samples + tests #3249
tmatsuo merged 19 commits into
GoogleCloudPlatform:masterfrom
Strykrol:snippetcleanup

Conversation

@Strykrol

@StrykrolStrykrol commented Apr 1, 2020

Copy link
Copy Markdown
Contributor

No description provided.

Strykrol added 10 commits April 1, 2020 12:21
@Strykrol
dialogflow: delete unused samples and corresponding tests for context…
0f238f5
… management
@Strykrol
dialogflow: delete unused samples and corresponding tests for detecti…
fafcd49
…ng intent with model selection
@Strykrol
dialogflow: delete unused samples for document management
334e66e
@Strykrol
dialogflow: clean up document management whitespace
7120305
@Strykrol
dialogflow: delete unused samples for entity management
53ad425
@Strykrol
dialogflow: delete tests for deleted entity management samples
a591a03
@Strykrol
dialogflow: delete tests for deleted document management samples
94abfa3
@Strykrol
dialogflow: delete unused samples and corresponding tests for entity …
5b0831a
…type management
@Strykrol
dialogflow: delete unused samples and corresponding tests for session…
5de592c
… entity type management and entity type management
@Strykrol
dialogflow: delete unused samples and corresponding tests for knowled…
2ae14ba
…ge base management
@Strykrol
Strykrol requested review from a team, nnegrey, sirtorry and telpirion as code ownersApril 1, 2020 20:00
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 1, 2020
@tmatsuotmatsuo mentioned this pull request Apr 23, 2020
Closed
@tmatsuotmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@kokoro-teamkokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuotmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@kokoro-teamkokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuo

tmatsuo commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

@Strykrol Here is the lint output:

./document_management.py:34:1: E302 expected 2 blank lines, found 1
def create_document(project_id, knowledge_base_id, display_name, mime_type,
^
./document_management.py:73:1: E305 expected 2 blank lines after class or function definition, found 1
if __name__ == '__main__':
^
./document_management.py:113:42: W292 no newline at end of file
args.content_uri) ^
./knowledge_base_management.py:70:66: W292 no newline at end of file
create_knowledge_base(args.project_id, args.display_name) ^

@Strykrol

Strykrol commented Apr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

Got it, fixing...

@tmatsuotmatsuo added kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Apr 23, 2020
@kokoro-teamkokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 23, 2020
@tmatsuo

tmatsuo commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

A flake filed: #3490
Restarting the build

@tmatsuotmatsuo added kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Apr 23, 2020
@tmatsuo
tmatsuo merged commit cc2e237 into GoogleCloudPlatform:masterApr 23, 2020
@tmatsuo

tmatsuo commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

@Strykrol Thanks! It's finally merged :)

@Strykrol

Strykrol commented Apr 24, 2020

Copy link
Copy Markdown
ContributorAuthor

Thank you for taking it to the finish line!

@tmatsuotmatsuo mentioned this pull request Apr 25, 2020
Closed
@Strykrol
Strykrol deleted the snippetcleanup branch April 28, 2020 17:29
busunkim96 pushed a commit to busunkim96/dialogflow-python-client-v2 that referenced this pull request Nov 30, 2020
@Strykrol@leahecole
dialogflow: remove unused samples + tests [(#3249)](GoogleCloudPlatfo…
847fcd6
…rm/python-docs-samples#3249)
* dialogflow: delete unused samples and corresponding tests for context management
* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection
* dialogflow: delete unused samples for document management
* dialogflow: clean up document management whitespace
* dialogflow: delete unused samples for entity management
* dialogflow: delete tests for deleted entity management samples
* dialogflow: delete tests for deleted document management samples
* dialogflow: delete unused samples and corresponding tests for entity type management
* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management
* dialogflow: delete unused samples and corresponding tests for knowledge base management
* flake8 lints
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
busunkim96 pushed a commit to googleapis/python-dialogflow that referenced this pull request Dec 9, 2020
@Strykrol@leahecole@busunkim96
dialogflow: remove unused samples + tests [(#3249)](GoogleCloudPlatfo…
98fa83d
…rm/python-docs-samples#3249)
* dialogflow: delete unused samples and corresponding tests for context management
* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection
* dialogflow: delete unused samples for document management
* dialogflow: clean up document management whitespace
* dialogflow: delete unused samples for entity management
* dialogflow: delete tests for deleted entity management samples
* dialogflow: delete tests for deleted document management samples
* dialogflow: delete unused samples and corresponding tests for entity type management
* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management
* dialogflow: delete unused samples and corresponding tests for knowledge base management
* flake8 lints
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Jan 18, 2023
@Strykrol@leahecole@busunkim96
dialogflow: remove unused samples + tests [(#3249)](#3249)
0885178
* dialogflow: delete unused samples and corresponding tests for context management
* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection
* dialogflow: delete unused samples for document management
* dialogflow: clean up document management whitespace
* dialogflow: delete unused samples for entity management
* dialogflow: delete tests for deleted entity management samples
* dialogflow: delete tests for deleted document management samples
* dialogflow: delete unused samples and corresponding tests for entity type management
* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management
* dialogflow: delete unused samples and corresponding tests for knowledge base management
* flake8 lints
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@telpiriontelpirion mentioned this pull request Jan 18, 2023
Closed
8 tasks
@yil532yil532 mentioned this pull request Feb 1, 2023
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Feb 6, 2023
@Strykrol@leahecole@dandhlee
dialogflow: remove unused samples + tests [(#3249)](#3249)
ab6f591
* dialogflow: delete unused samples and corresponding tests for context management
* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection
* dialogflow: delete unused samples for document management
* dialogflow: clean up document management whitespace
* dialogflow: delete unused samples for entity management
* dialogflow: delete tests for deleted entity management samples
* dialogflow: delete tests for deleted document management samples
* dialogflow: delete unused samples and corresponding tests for entity type management
* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management
* dialogflow: delete unused samples and corresponding tests for knowledge base management
* flake8 lints
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
telpirion pushed a commit that referenced this pull request Mar 13, 2023
@Strykrol@leahecole@telpirion
dialogflow: remove unused samples + tests [(#3249)](#3249)
70fb0b9
* dialogflow: delete unused samples and corresponding tests for context management
* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection
* dialogflow: delete unused samples for document management
* dialogflow: clean up document management whitespace
* dialogflow: delete unused samples for entity management
* dialogflow: delete tests for deleted entity management samples
* dialogflow: delete tests for deleted document management samples
* dialogflow: delete unused samples and corresponding tests for entity type management
* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management
* dialogflow: delete unused samples and corresponding tests for knowledge base management
* flake8 lints
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
vchudnov-g pushed a commit to googleapis/google-cloud-python that referenced this pull request Sep 20, 2023
@Strykrol@leahecole@busunkim96
dialogflow: remove unused samples + tests [(#3249)](GoogleCloudPlatfo…
c3e6909
…rm/python-docs-samples#3249)
* dialogflow: delete unused samples and corresponding tests for context management
* dialogflow: delete unused samples and corresponding tests for detecting intent with model selection
* dialogflow: delete unused samples for document management
* dialogflow: clean up document management whitespace
* dialogflow: delete unused samples for entity management
* dialogflow: delete tests for deleted entity management samples
* dialogflow: delete tests for deleted document management samples
* dialogflow: delete unused samples and corresponding tests for entity type management
* dialogflow: delete unused samples and corresponding tests for session entity type management and entity type management
* dialogflow: delete unused samples and corresponding tests for knowledge base management
* flake8 lints
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sirtorrysirtorryAwaiting requested review from sirtorry
@telpiriontelpirionAwaiting requested review from telpirion
3 more reviewers
@tmatsuotmatsuotmatsuo approved these changes
@gguussgguussgguuss approved these changes
@nnegreynnegreynnegrey approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@gguussgguuss

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@Strykrol@tmatsuo@gguuss@nnegrey@googlebot@kokoro-team@leahecole