Skip to content

Talent v4beta1 samples [Restoring deleted branch samples] - #3273

Merged
tmatsuo merged 44 commits into
GoogleCloudPlatform:masterfrom
munkhuushmgl:talent-v4beta1-samples
May 21, 2020
Merged

Talent v4beta1 samples [Restoring deleted branch samples]#3273
tmatsuo merged 44 commits into
GoogleCloudPlatform:masterfrom
munkhuushmgl:talent-v4beta1-samples

Conversation

@munkhuushmgl

@munkhuushmglmunkhuushmgl commented Apr 3, 2020•
edited by tmatsuo
Loading

Copy link
Copy Markdown
Contributor

No description provided.

@munkhuushmgl
munkhuushmgl requested a review from a team as a code ownerApril 3, 2020 19:13
@googlebotgooglebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 3, 2020
@munkhuushmgl

munkhuushmgl commented Apr 3, 2020

Copy link
Copy Markdown
ContributorAuthor

@kurtisvg please add DO_NOT_MERGE label.

@kurtisvgkurtisvg added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 3, 2020
@tmatsuo
tmatsuo self-requested a review April 6, 2020 21:25
@munkhuushmgl

munkhuushmgl commented Apr 23, 2020

Copy link
Copy Markdown
ContributorAuthor

@tmatsuo Hey Takashi, I just added tests and formatting to these autogenerated python code.

I do not have permission to modify anything in this PR.
Could you remove this DO_NOT_MERGE label ?

@munkhuushmgl
munkhuushmgl marked this pull request as draft April 23, 2020 22:07
@tmatsuotmatsuo removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 29, 2020
@tmatsuo
tmatsuo marked this pull request as ready for review April 29, 2020 03:07
tmatsuo
tmatsuo suggested changes Apr 29, 2020
View reviewed changes

@tmatsuotmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed until the 12nd file, but I think there are many similar issues throughout the sample.

Can you fix what I pointed out throughout the files?

Comment threadjobs/v4/job_search_autocomplete_job_title.py
Comment threadjobs/v4/job_search_autocomplete_job_title_test.py Outdated
Comment threadjobs/v4/job_search_batch_update_jobs.py Outdated
Comment threadjobs/v4/job_search_create_company_test.py Outdated
Comment threadjobs/v4/job_search_create_company_test.py Outdated
Comment threadjobs/v4/job_search_create_job_custom_attributes_test.py Outdated
Comment threadjobs/v4/job_search_create_job_custom_attributes_test.py Outdated
@kurtisvgkurtisvg assigned tmatsuo and unassigned kurtisvgMay 11, 2020
@kurtisvg

kurtisvg commented May 11, 2020

Copy link
Copy Markdown
Contributor

@munkhuushmgl - Could you please address the feedback on this PR? We have a fix it around trying to reduce open issues/PRs on this repo this week.

@munkhuushmgl

munkhuushmgl commented May 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@munkhuushmgl - Could you please address the feedback on this PR? We have a fix it around trying to reduce open issues/PRs on this repo this week.

@kurtisvg I will address the feedback EOD

@munkhuushmgl
munkhuushmgl requested a review from tmatsuoMay 19, 2020 18:13
tmatsuo
tmatsuo reviewed May 19, 2020
View reviewed changes

@tmatsuotmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking great. Few more requests. I hope it's the last roundtrip.

Comment threadjobs/v4beta1/conftest.py Outdated
Comment threadjobs/v4beta1/job_search_delete_tenant_test.py Outdated
Comment threadjobs/v4beta1/job_search_delete_job_test.py Outdated
Comment threadjobs/v4beta1/job_search_delete_company_test.py Outdated
Comment threadjobs/v4beta1/testing/requirement.txt Outdated
Comment threadjobs/v4beta1/requirements-test.txt Outdated
Comment threadjobs/v4beta1/conftest.py Outdated
@munkhuushmgl
munkhuushmgl requested a review from tmatsuoMay 20, 2020 21:37
tmatsuo
tmatsuo approved these changes May 20, 2020
View reviewed changes

@tmatsuotmatsuo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment threadjobs/v4beta1/job_search_delete_job_test.py Outdated
Comment threadjobs/v4beta1/job_search_delete_tenant_test.py Outdated
@munkhuushmgl

munkhuushmgl commented May 20, 2020

Copy link
Copy Markdown
ContributorAuthor

@tmatsuo Thanks for the feedback, I do not have permission to merge this,
Could you merge this for me once tests are passed?

@tmatsuo
tmatsuo merged commit d5e8bde into GoogleCloudPlatform:masterMay 21, 2020
busunkim96 pushed a commit to busunkim96/python-talent that referenced this pull request Sep 24, 2020
@munkhuushmglTakashi Matsuo
Talent v4beta1 samples [Restoring deleted branch samples] [(#3273)](G…
fde0c27
…oogleCloudPlatform/python-docs-samples#3273)
* restored deleted samples
* fixed lint issues
* added tests and formatted code
* corrected test req.txt file
* made requested changes and added return val for samples
* added secrets.txt to bash, script
* fixed the lint
* moved to requirements-test.txt
* delete resources in teardown just in case
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
* added some spacing
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
moved to requirements-test.txt
delete resources in teardown just in case
added some spacing
* fixed merge conflicts
* added conftest.py and refactored samples with loop
* removed talent secret.txt from bash script
* fixed the lint issue
* removed unnecessary env vars
* deleted global random ids, deleted unnecessary setup code from delete tests
* removed unused imports
* removed pytest
* removed unused IDs
* deleted unused uuid imports
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
busunkim96 pushed a commit to googleapis/python-talent that referenced this pull request Sep 25, 2020
@munkhuushmglTakashi Matsuo@busunkim96
Talent v4beta1 samples [Restoring deleted branch samples] [(#3273)](G…
e939487
…oogleCloudPlatform/python-docs-samples#3273)
* restored deleted samples
* fixed lint issues
* added tests and formatted code
* corrected test req.txt file
* made requested changes and added return val for samples
* added secrets.txt to bash, script
* fixed the lint
* moved to requirements-test.txt
* delete resources in teardown just in case
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
* added some spacing
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
moved to requirements-test.txt
delete resources in teardown just in case
added some spacing
* fixed merge conflicts
* added conftest.py and refactored samples with loop
* removed talent secret.txt from bash script
* fixed the lint issue
* removed unnecessary env vars
* deleted global random ids, deleted unnecessary setup code from delete tests
* removed unused imports
* removed pytest
* removed unused IDs
* deleted unused uuid imports
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
xtineskim pushed a commit that referenced this pull request Nov 11, 2022
@munkhuushmglTakashi Matsuo@busunkim96
Talent v4beta1 samples [Restoring deleted branch samples] [(#3273)](#…
1654c75
…3273)
* restored deleted samples
* fixed lint issues
* added tests and formatted code
* corrected test req.txt file
* made requested changes and added return val for samples
* added secrets.txt to bash, script
* fixed the lint
* moved to requirements-test.txt
* delete resources in teardown just in case
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
* added some spacing
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
moved to requirements-test.txt
delete resources in teardown just in case
added some spacing
* fixed merge conflicts
* added conftest.py and refactored samples with loop
* removed talent secret.txt from bash script
* fixed the lint issue
* removed unnecessary env vars
* deleted global random ids, deleted unnecessary setup code from delete tests
* removed unused imports
* removed pytest
* removed unused IDs
* deleted unused uuid imports
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
@xtineskimxtineskim mentioned this pull request Nov 11, 2022
Merged
8 tasks
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@munkhuushmglTakashi Matsuo@dandhlee
Talent v4beta1 samples [Restoring deleted branch samples] [(#3273)](#…
bb1d01a
…3273)
* restored deleted samples
* fixed lint issues
* added tests and formatted code
* corrected test req.txt file
* made requested changes and added return val for samples
* added secrets.txt to bash, script
* fixed the lint
* moved to requirements-test.txt
* delete resources in teardown just in case
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
* added some spacing
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
moved to requirements-test.txt
delete resources in teardown just in case
added some spacing
* fixed merge conflicts
* added conftest.py and refactored samples with loop
* removed talent secret.txt from bash script
* fixed the lint issue
* removed unnecessary env vars
* deleted global random ids, deleted unnecessary setup code from delete tests
* removed unused imports
* removed pytest
* removed unused IDs
* deleted unused uuid imports
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Jun 4, 2023
@munkhuushmglTakashi Matsuo@busunkim96
Talent v4beta1 samples [Restoring deleted branch samples] [(#3273)](G…
66deb64
…oogleCloudPlatform/python-docs-samples#3273)
* restored deleted samples
* fixed lint issues
* added tests and formatted code
* corrected test req.txt file
* made requested changes and added return val for samples
* added secrets.txt to bash, script
* fixed the lint
* moved to requirements-test.txt
* delete resources in teardown just in case
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
* added some spacing
* restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
restored deleted samples
fixed lint issues
added tests and formatted code
corrected test req.txt file
made requested changes and added return val for samples
added secrets.txt to bash, script
fixed the lint
moved to requirements-test.txt
delete resources in teardown just in case
added some spacing
* fixed merge conflicts
* added conftest.py and refactored samples with loop
* removed talent secret.txt from bash script
* fixed the lint issue
* removed unnecessary env vars
* deleted global random ids, deleted unnecessary setup code from delete tests
* removed unused imports
* removed pytest
* removed unused IDs
* deleted unused uuid imports
Co-authored-by: Takashi Matsuo <tmatsuo@google.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@tmatsuotmatsuotmatsuo approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@tmatsuotmatsuo

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@munkhuushmgl@kurtisvg@tmatsuo@googlebot